Open
Conversation
chermehdi
requested changes
Nov 10, 2020
Owner
chermehdi
left a comment
chermehdi
left a comment
There was a problem hiding this comment.
LGTM
Although it would be nice to add a test for this as well.
Contributor
Author
|
I'm working on it now |
Contributor
Author
|
i'm tired, I will work on it later, and add |
Contributor
Author
|
I have added a test using testable examples, I'm sure its not perfect but I don't know how to use testing framework |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a partial fix of the issue #2