Skip to content

Fix printf the extra interface #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anouard24 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix printf the extra interface #3

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a921450
Fix printf the extra interface
anouard24 Nov 8, 2020
57a505b
unpack args to printf
anouard24 Nov 10, 2020
551d89b
Add test for printf
anouard24 Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion std/builtins.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,12 @@ var Builtins = []*Builtin{
transArgs = append(transArgs, extractPrimitive(args[i]))
}
format := args[0].(*CometStr)
fmt.Printf(format.Value, transArgs)

if len(transArgs) > 0 {
fmt.Printf(format.Value, transArgs)
} else {
fmt.Printf(format.Value)
}
return NopInstance
},
},
Expand Down