Skip to content

Conversation

@pierre-viret
Copy link
Contributor

The quotes of the localized messages were not displayed and unit test "LocalisationHelperTest" crashed because the argument were not replaced.

  • DataReaderFacade.java: use the LocalisationHelper.getString with arguments
    instead of performing the format ourself.
  • localStrings_fr.properties: replace each single quote with two single
    quotes as stated in the javadoc of MessageFormat class:
    https://docs.oracle.com/javase/8/docs/api/java/text/MessageFormat.html#patterns
    Otherwise the single quote won't appear in the message and the arguments are not parsed.

The quotes of the localized messages were not displayed and unit test "LocalisationHelperTest" crashed because the argument were not replaced.
- DataReaderFacade.java: use the LocalisationHelper.getString with arguments
instead of performing the format ourself.
- localStrings_fr.properties: replace each single quote with two single 
quotes as stated in the javadoc of MessageFormat class:
https://docs.oracle.com/javase/8/docs/api/java/text/MessageFormat.html#patterns
Otherwise the single quote won't appear in the message and the arguments are not parsed.
@chewiebug
Copy link
Owner

Hi Pierre,

Thank you very much for your contribution! I have merged it into develop branch.

For a next contribution, you could help me make the merge much easier, if you

  • branched off develop branch; that's my main branch for development (master is the last release -> rather outdated), my automated checks will also be much more meaningful.
  • wouldn't introduce so many "dummy" changes (\u00E9 -> \u00e9 in the properties file; they hide, what you intended to change and make review difficult for me)

Best regards,
Jörg

@chewiebug chewiebug closed this Feb 10, 2016
@chewiebug chewiebug self-assigned this Feb 10, 2016
@chewiebug chewiebug added the bug label Feb 10, 2016
@chewiebug chewiebug added this to the 1.35 milestone Feb 10, 2016
@pierre-viret
Copy link
Contributor Author

Hello Jörg

Thank you for your feedback. Sorry that I have chosen the master branch: I didn't notice that we have to work with the develop branch, but now it's clear.
Concerning the changes like \u00E9 -> \u00e9: they must have to do with my git settings because locally I didn't have seen them when I have committed and pushed to my remote repository. I have only seen these changes when I have made the pull request. I will check this to avoid such annoyance in the future.

Best regards,
Pierre

@chewiebug
Copy link
Owner

chewiebug commented Feb 11, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants