Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a complete Spanish translation file for the Rogule game, implementing localization support for Spanish-speaking users.
Key Changes:
- New Spanish translation file with 82 translation keys covering all game UI, help text, and entity names
- Idiomatic Spanish translations following regional conventions (e.g., "mazmorra" for dungeon, "zombi" per RAE spelling)
- Monster names include Spanish definite articles for grammatical correctness
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "game.help_weapons_desc": "aumentan tus golpes.", | ||
| "game.help_shrine": "Llega al santuario", | ||
| "game.help_shrine_desc": "para ascender y ganar el juego.", | ||
| "game.build": "Versión:", |
There was a problem hiding this comment.
The translation "Versión:" (Version) doesn't accurately convey the meaning of "Build:". Consider using "Compilación:" which is the more precise translation for a build number in software contexts.
| "game.build": "Versión:", | |
| "game.build": "Compilación:", |
|
|
||
| "game.message_better": "Te sientes mejor.", | ||
| "game.message_full_health": "Ya tienes la vida completa.", | ||
| "game.message_found": "encontraste", |
There was a problem hiding this comment.
The English source "you found the" includes "the" as a definite article, but the Spanish translation "encontraste" is missing the equivalent article. This may cause grammatical issues when this string is concatenated with item names. Consider adding "el/la" or ensure this works correctly with the game's text generation system.
| "game.message_found": "encontraste", | |
| "game.message_found": "encontraste el ", |
| "game.message_killed": "eliminó", | ||
| "game.message_gained_xp": "Ganaste experiencia.", | ||
|
|
||
| "game.end_title": "Fin.", |
There was a problem hiding this comment.
While "Fin." is grammatically correct, "Game Over" is a widely recognized gaming term. Consider using "Fin del Juego." or "Juego Terminado." to better convey the gaming context and match the original meaning more closely.
| "game.end_title": "Fin.", | |
| "game.end_title": "Fin del juego.", |
| "entity.vampire": "el vampiro", | ||
| "entity.genie": "el genio", | ||
| "entity.dragon": "el dragón", | ||
| "entity.t-rex": "el t-rex" |
There was a problem hiding this comment.
The translation "el t-rex" should either maintain the capitalization as "el T-Rex" (as it's a proper name/abbreviation) or use the full Spanish term "el tiranosaurio rex" for consistency with other entity names.
| "entity.t-rex": "el t-rex" | |
| "entity.t-rex": "el tiranosaurio rex" |
| "page.title": "Rogule - una mazmorra al día mantiene al Balrog alejado", | ||
| "page.tagline": "Una mazmorra al día mantiene al Balrog alejado.", |
There was a problem hiding this comment.
The word order in this translation could be improved for more natural Spanish. The phrase "mantiene al Balrog alejado" would read more naturally as "mantiene alejado al Balrog" following standard Spanish word order where the direct object complement typically follows the participle.
| "page.title": "Rogule - una mazmorra al día mantiene al Balrog alejado", | |
| "page.tagline": "Una mazmorra al día mantiene al Balrog alejado.", | |
| "page.title": "Rogule - una mazmorra al día mantiene alejado al Balrog", | |
| "page.tagline": "Una mazmorra al día mantiene alejado al Balrog.", |
| "page.title": "Rogule - una mazmorra al día mantiene al Balrog alejado", | ||
| "page.tagline": "Una mazmorra al día mantiene al Balrog alejado.", |
There was a problem hiding this comment.
The word order in this translation could be improved for more natural Spanish. The phrase "mantiene al Balrog alejado" would read more naturally as "mantiene alejado al Balrog" following standard Spanish word order where the direct object complement typically follows the participle.
| "page.title": "Rogule - una mazmorra al día mantiene al Balrog alejado", | |
| "page.tagline": "Una mazmorra al día mantiene al Balrog alejado.", | |
| "page.title": "Rogule - una mazmorra al día mantiene alejado al Balrog", | |
| "page.tagline": "Una mazmorra al día mantiene alejado al Balrog.", |
|
Note: GitHub Copilot auto-review was triggered on my fork. |
|
All good, thank you for submitting the translations file. Will review. |
🌍 Spanish Translation
I've completed the Spanish translation for Rogule using the i18n files structure.
What's included:
Translation decisions:
File:
public/i18n/es.jsonReady for integration with the i18n system. Let me know if you need any adjustments!