Skip to content

Intro to storybook Update Korean translation to latest version#812

Open
wihyanghoon wants to merge 6 commits intochromaui:masterfrom
wihyanghoon:intro-to-storybook/react/ko
Open

Intro to storybook Update Korean translation to latest version#812
wihyanghoon wants to merge 6 commits intochromaui:masterfrom
wihyanghoon:intro-to-storybook/react/ko

Conversation

@wihyanghoon
Copy link

Based on react/en, converted the source code from JavaScript to TypeScript and slightly updated the content accordingly.

@jonniebigodes
Copy link
Collaborator

@wihyanghoon, before I can take a pass from a technical perspective, can you adjust the translation based on #815 so that we can align it with the latest English version?

Let me know and we'll go from there.

Hope you have a great day
Stay safe

@wihyanghoon
Copy link
Author

Sure, I’ll adjust the translation based on #815 so it aligns with the latest English version.
I’ll let you know once it’s updated so you can review from a technical perspective.

Thanks for checking in!

@jonniebigodes
Copy link
Collaborator

@wihyanghoon sorry for the radio silence on this, but I've been tasked with other documentation changes that required my immediate attention. When you have a moment, can you take another look into this pull request and adjust it based on the current English version as there is still some outdated content so that I can start reviewing it and reach out to our community for a content review?

Let me know and we'll go from there.

Hope you have a great day.

Stay safe

@yoon-jeong-ho15
Copy link

Hello, @wihyanghoon @jonniebigodes. I'm new to GitHub community, so I don't really know how things are done. Since It has been half year from last commit, I would like to help finish this translation if it is okay. I'll open a new PR that includes #815 and minor adjustments.

@jonniebigodes
Copy link
Collaborator

@yoon-jeong-ho15, appreciate you reaching out, and sorry for not following up with you sooner. From my end, I'm all good, and if @wihyanghoon has no issues, I'm more than ok to close this in favor of your pull request.

I'm going to take a technical look at your pull request #828 and follow up with you tomorrow. Sounds good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants