Add support for custom block models#1332
Draft
leMaik wants to merge 44 commits intochunky-dev:masterfrom
Draft
Conversation
a89c73c to
664366e
Compare
Member
|
What's the progress? |
Member
Author
|
@Zhou-Shilin Needs a rebase and is not ready yet. There is a checklist above. |
730ae99 to
7ba6d73
Compare
|
A varied handful of mods and a world for testing 1.20.1 modded block support: World: no errors test.zip Mods: Mods to test.zip (I had to remove a few mods so I didn't go over the upload limit like chipped and MTR) Happy testing! |
067ff80 to
31c5748
Compare
…ert large blocks to block entities automatically.
…lipped west textures).
…ck not being rendered.
…onverting a block to an entity.
…any dynamic lookups while rendering.
…replaced with non-jsonmodel blocks.
31c5748 to
0103a87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR adds support for custom block models. It can (and currently is hard-coded to do so) also replace Chunky's built-in models by models generated from the minecraft jar file.
Caveats:
entityLoadingPreferencescausing them not to load by defaultTintedQuadand use thetintsarray instead (as in hard-coded models)JsonModelandMultipartJsonModelshouldn't beBlocksminecraft:pitcher_plantTo get the latest build of this PR, follow this guide: https://github.com/leMaik/chunky-pr-as-update-site
Due to a bug, you currently have to open the resource pack dialog and apply the resourcepacks after launching this Chunky build. Then it will load the models. Reload the world if you only see purple blocks.
Fixes #88 and fixes #426.