Creating evangelikus-hittudomanyi-egyetem.csl for Lutheran Theological University#8094
Creating evangelikus-hittudomanyi-egyetem.csl for Lutheran Theological University#8094Specialman8 wants to merge 11 commits intocitation-style-language:masterfrom
Conversation
|
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing: If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
|
😟 There are some issues with your submission. 5 tests failedehe-note: must validate against the CSL 1.0.1 schema ehe-note: must have a "class" attribute that matches the "citation-format" attribute ehe-note: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa") ehe-note: "self" link must match the style ID ehe-note: must have the correct Creative Commons BY-SA license URL Please check the test report for details. |
|
😟 There are some issues with your submission. 1 test failedehe-note: must validate against the CSL 1.0.1 schema Please check the test report for details. |
Removed the GitHub URI from the author section.
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: ehe-note.csl (new)CSL search by example. Citation style editor. https://editor.citationstyles.org/searchByExample/. elérés: 2012. december 15.; Fenner és mtsai. 2019. |
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: ehe-note.csl (new)CSL search by example. Citation style editor. https://editor.citationstyles.org/searchByExample/. elérés: 2012. december 15.; Fenner és mtsai. 2019. |
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: evangelikus-hittudomanyi-egyetem.csl (new)CSL search by example. Citation style editor. https://editor.citationstyles.org/searchByExample/. elérés: 2012. december 15.; Fenner és mtsai. 2019. |
|
Dear Contributors, I know there are 180 other PRs and I don't want to seem impatient or disrespectful. Thanks in advance. |
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: evangelikus-hittudomanyi-egyetem.csl (new)CSL search by example. Citation style editor. https://editor.citationstyles.org/searchByExample/. elérés: 2012. december 15.; Fenner és mtsai. 2019. |
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: evangelikus-hittudomanyi-egyetem.csl (new)CSL search by example. Citation style editor. https://editor.citationstyles.org/searchByExample/. elérés: 2012. december 15.; Fenner és mtsai. 2019. |
POBrien333
left a comment
There was a problem hiding this comment.
Thanks for your submission here and in citation-style-language/locales#423
This style needs a good bit of work to get it in shape. I didn't mention all things.
If you get the remaining terms in the locale translated we can prioritise this PR also. Thanks :)
| </else> | ||
| </choose> | ||
| </macro> | ||
| <macro name="locator"> |
There was a problem hiding this comment.
this can probably be reduced to label+variable of "locator". Or is there a need to divy them all out?
There was a problem hiding this comment.
This probably is still valid.
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: evangelikus-hittudomanyi-egyetem.csl (new)CSL search by example. Citation style editor. https://editor.citationstyles.org/searchByExample/. elérés: 2012. december 15.; Fenner és mtsai. 2019. |
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: evangelikus-hittudomanyi-egyetem.csl (new)CSL search by example. Citation style editor. https://editor.citationstyles.org/searchByExample/. elérés: 2012. december 15.; Fenner és mtsai. 2019. |
|
Thank you very much! You were very precise. |
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: evangelikus-hittudomanyi-egyetem.csl (new)CSL search by example. Citation style editor. https://editor.citationstyles.org/searchByExample/. elérés: 2012. december 15.; Fenner és mtsai. 2019. |
| <if match="any" variable="author editor editor-translator collection-editor"> | ||
| <group delimiter=" "> | ||
| <group> | ||
| <names variable="author" delimiter="–"> |
There was a problem hiding this comment.
All of these delimiter="–" are not necessary since you already set it o <citation....
You can set it even more globally on line 2.
| <et-al/> | ||
| <substitute> | ||
| <names variable="editor" delimiter="–"> | ||
| <name form="short" delimiter-precedes-et-al="never" delimiter-precedes-last="never" et-al-min="4" sort-separator=""> |
There was a problem hiding this comment.
Unless you're styling the editor or other substitutes differently to the author, all this code is an unnecessary duplication.
| </group> | ||
| </if> | ||
| <else> | ||
| <group delimiter=" " suffix="."> |
There was a problem hiding this comment.
Your citations are currently rendered like so:
Campbell–Pedersen 2007.; Mares 2001.; Isaacson 2011.; Foderaro 2012.; Borges 1999.
Se the dot at the end that looks odd to me. Is that a "Hungarian" thing or an error/bug?
| </else> | ||
| </choose> | ||
| </macro> | ||
| <macro name="locator"> |
There was a problem hiding this comment.
This probably is still valid.
| <!--Bibliography-print-title--> | ||
| <macro name="title-book"> | ||
| <group delimiter=" "> | ||
| <text variable="title" font-style="italic" suffix="."/> |
There was a problem hiding this comment.
Move this into it's own group, setting the dot as a group delimiter, instead of using a suffix.
| </macro> | ||
| <macro name="access-webpage"> | ||
| <group delimiter=" "> | ||
| <text term="accessed" suffix=":"/> |
There was a problem hiding this comment.
Set the colon on the group level
| <text term="ibid"/> | ||
| </group> | ||
| </else-if> | ||
| <else-if type="webpage" match="any"> |
There was a problem hiding this comment.
I would do this differently.
Render the name for websites via the else and author-short macro, but then add the condtional for the webpage/post/post-weblog inside that else to show the URL+access details.

CSL Styles Pull Request Template
You're about to create a pull request to the CSL styles repository.
If you haven't done so already, see https://github.com/citation-style-language/styles/blob/master/CONTRIBUTING.md for instructions on how to contribute, and https://github.com/citation-style-language/styles/blob/master/STYLE_REQUIREMENTS.md for the requirements a style must meet before acceptance.
In addition, please fill out the pull request template below.
Description
This is the first citation style for the Lutheran Theological University in Hungary. It was created according to the standards of Luther Publisher in Budapest. The style is used by Lutheran journals, the publisher and the university.
Checklist
<info>block at the beginning of the file withrel="template".rel="documentation".<author>of the style or<contributor>for a style update.<text variable="page" prefix="pp. "/>).<text value="...if not absolutely necessary.