Skip to content

Revert "fix(tanstack-start): Fix event handler return type mismatch"#5068

Merged
LekoArts merged 4 commits intomainfrom
revert-5051-fix/tanstack-start-event-handler
Feb 3, 2025
Merged

Revert "fix(tanstack-start): Fix event handler return type mismatch"#5068
LekoArts merged 4 commits intomainfrom
revert-5051-fix/tanstack-start-event-handler

Conversation

@wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Feb 2, 2025

Reverts #5051

This reversion is no longer needed (and didn't actually fix the issue) as the underlying h3 version compatibility issue
has been resolved upstream in the TanStack Router repository (TanStack/router#3310)

@linear
Copy link

linear bot commented Feb 2, 2025

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2025

🦋 Changeset detected

Latest commit: 8b4ceeb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 10:29am

@wobsoriano wobsoriano marked this pull request as ready for review February 3, 2025 05:19
@panteliselef
Copy link
Contributor

@wobsoriano If we revert would that be a breaking change ? If it is are we consider it a bug and thus justifiable ?

@wobsoriano
Copy link
Member Author

@wobsoriano If we revert would that be a breaking change ? If it is are we consider it a bug and thus justifiable ?

This should not be a breaking change and only an internal type update. I thought I fixed it locally when testing, turns out I have a cached dependency. My previous update didn’t really do anything at all so reverting it should be safe 🫡

@LekoArts LekoArts merged commit eea8ce0 into main Feb 3, 2025
27 checks passed
@LekoArts LekoArts deleted the revert-5051-fix/tanstack-start-event-handler branch February 3, 2025 12:30
wobsoriano added a commit that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants