Fix dropped errors in manifold.deferred/timeout!
#248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerGuteMoritz
changed the title
d/timeout!manifold.deferred/timeout!
When putting the result deferred `d` in an error state, deferred returned by `chain` would be detected as a dropped error because it's only used to attach a side-effecting callback for cancelling the timeout. The fix then is to use `on-realized` instead to attach a handler for both cases. As a consequence, timeouts are now also properly cancelled when the result deferred is put in an error state, freeing up resources in a more timely fashion. This fixes one of the causes of clj-commons/aleph#766, as well as 2 of the 3 dropped errors in `manifold.go-off-test`. Also, add dedicated tests for `d/timeout!`.
DerGuteMoritz
force-pushed
the
fix-dropped-errors-in-timeout
branch
from
9b9c934 to
ed6636b
Compare
This was referenced Sep 22, 2025
valerauko
reviewed
Sep 30, 2025
Comment on lines
+260
to
+262
| t (d/timeout! d 1000)] | ||
| (d/error! d ex) | ||
| (is (= ex (deref (capture-error t) 100 ::error)))))) |
There was a problem hiding this comment.
do these numbers need to be so big?
if smaller works too that'd be better for faster tests
Suggested change
| t (d/timeout! d 1000)] | |
| (d/error! d ex) | |
| (is (= ex (deref (capture-error t) 100 ::error)))))) | |
| t (d/timeout! d 20)] | |
| (d/error! d ex) | |
| (is (= ex (deref (capture-error t) 10 ::error)))))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When putting the result deferred
din an error state, deferred returned bychainwould be detected as a dropped error because it's only used to attach a side-effecting callback for cancelling the timeout. The fix then is to useon-realizedinstead to attach a handler for both cases. As a consequence, timeouts are now also properly cancelled when the result deferred is put in an error state, freeing up resources in a more timely fashion.This fixes one of the causes of clj-commons/aleph#766, as well as 2 of the 3 dropped errors in
manifold.go-off-test.Also, add dedicated tests for
d/timeout!.Based on #245.