Skip to content

Comments

Fix error handling in RDS tag reconciliation#403

Merged
markdboyd merged 1 commit intomainfrom
fix-error-handling
Mar 12, 2025
Merged

Fix error handling in RDS tag reconciliation#403
markdboyd merged 1 commit intomainfrom
fix-error-handling

Conversation

@markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • remove log.Fatal and return error to avoid early program termination

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just optimizing the error handling

@markdboyd markdboyd requested a review from a team as a code owner March 12, 2025 15:45
@markdboyd markdboyd added this pull request to the merge queue Mar 12, 2025
Merged via the queue into main with commit 0d48b6c Mar 12, 2025
1 check passed
@markdboyd markdboyd deleted the fix-error-handling branch March 12, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants