Remove "pq-experimental" and "underscore-wildcards" features #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note: The CI failure appears to be due to an unrelated issue: #392 |
Closed
cjpatton
force-pushed
the
cjpatton/drop-pq-experimental
branch
from
9f00d5c to
379450a
Compare
When set, these features cause boring-sys to apply patches to the source before building BoringSSL. Instead, apply these patches unconditionally. This matches the semantcis of pre-compiled BoringSSL, where the library is expected to provide the features implemented by these patches. We might want to do the same for "rpk", but currenlty our internal build of boringSSL doesn't appear to supply the following APIs: ``` ffi::SSL_CTX_set_nullchain_and_key ffi::SSL_CTX_set_server_raw_public_key_certificate ```
cjpatton
force-pushed
the
cjpatton/drop-pq-experimental
branch
from
379450a to
bfdee23
Compare
Collaborator
Author
|
Per offline discussion with @ghedo: We're not in a position right now internally to ensure that every build of boringSSL in use implements the same feature set. Dropping the "underscore-wildcards" in particular would cause some grief. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When set, these features cause boring-sys to apply patches to the source before building BoringSSL. Instead, apply these patches unconditionally. This matches the semantcis of pre-compiled BoringSSL, where the library is expected to provide the features implemented by these patches.
We might want to do the same for "rpk", but currenlty our internal build of boringSSL doesn't appear to supply the following APIs: