Update react pages guide and react build-configuration not to use/mention create-react-app
#17499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dario-piotrowicz
requested review from
a team,
GregBrimble,
IgorMinar,
aninibread,
jculvey and
tanushree-sharma
as code owners
github-actions
bot
assigned
aninibread,
GregBrimble,
IgorMinar,
jculvey and
tanushree-sharma
This was referenced Oct 13, 2024
dario-piotrowicz
force-pushed
the
dario/16379/react-pages-guide-no-cra
branch
from
65aa14e to
e2de00b
Compare
Deploying cloudflare-docs with
|
| Latest commit: |
c880e84
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://979e9109.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://dario-16379-react-pages-guid.cloudflare-docs-7ou.pages.dev |
Contributor
|
Files with changes (up to 15) |
…tion `create-react-app` partially addresses #16379
dario-piotrowicz
force-pushed
the
dario/16379/react-pages-guide-no-cra
branch
from
e2de00b to
c880e84
Compare
ToriLindsay
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses #16379
Summary
create-cloudflaredoes not usecreate-react-appso our React pages guide mentioning thatcreate-react-appis being used is incorrect, in this PR I am removing such outdated/incorrect reference.Moreover I am also updating the react build configuration not to use
create-react-appsince it is no longer (and hasn't been for a while) the recommended too for creating react applications.