Fix durable-object and observability sections of wrangler.toml docs #17800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add missing brace in renamed_classes
* fix type info * remove duplicate example toml key * link to logpush info
It is not a binding. It is a script-setting, which lives somewhere between triggers and versioned settings (including bindings).
taylorlee
requested review from
a team,
GregBrimble,
dario-piotrowicz,
irvinebroque,
penalosa and
petebacondarwin
as code owners
taylorlee
commented
Oct 25, 2024
|
|
||
| - Whether Wrangler should keep variables configured in the dashboard on deploy. Refer to [source of truth](#source-of-truth). | ||
|
|
||
| - `migrations` <Type text="object[]" /> <MetaInfo text="optional" /> |
Contributor
Author
There was a problem hiding this comment.
cc @vy-ton (don't have permission to add you as reviewer...)
taylorlee
commented
Oct 25, 2024
| Setting `node_compat = true` will add polyfills for Node.js built-in modules and globals to your Worker's code, when bundled with Wrangler. | ||
| This is powered by `@esbuild-plugins/node-globals-polyfill` which in itself is powered by [rollup-plugin-node-polyfills](https://github.com/ionic-team/rollup-plugin-node-polyfills/). | ||
|
|
||
| - `logpush` <Type text="boolean" /> <MetaInfo text="optional" /> |
Contributor
Author
There was a problem hiding this comment.
cc @rohinlohe @tanushree-sharma (don't have permission to add you as reviewer...)
GregBrimble
approved these changes
Oct 28, 2024
irvinebroque
approved these changes
Oct 28, 2024
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
…17800) * [Workers] Document Durable Object migrations in configuration and add missing brace in renamed_classes * [Workers] Fix observabilty and logpush wrangler configuration * fix type info * remove duplicate example toml key * link to logpush info * [Workers] lift observability in wrangler configuration It is not a binding. It is a script-setting, which lives somewhere between triggers and versioned settings (including bindings).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[Workers] Document Durable Object migrations in configuration
and add missing brace in renamed_classes
[Workers] Fix observabilty and logpush wrangler configuration
[Workers] lift observability in wrangler configuration
It is not a binding. It is a script-setting, which lives somewhere
between triggers and versioned settings (including bindings).
Documentation checklist