-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Adding information to format of caPool option #17867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The current information for the caPool option is a bit vauge on what to actually enter here. Added information provided by another CF Employee to the doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 files reviewed, 1 total issue(s) found.
|
|
||
| Path to the certificate authority (CA) for the certificate of your origin. This option should be used only if your certificate is not signed by Cloudflare. | ||
|
|
||
| *Format:* The CA Pool option typically expects a path to a certificate store file or a bundle file in .pem or .crt format. This file should contain one or more trusted root CA certificates. It’s usually not a URL; rather, it’s a local file path where your trusted certificates are stored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| *Format:* The CA Pool option typically expects a path to a certificate store file or a bundle file in .pem or .crt format. This file should contain one or more trusted root CA certificates. It’s usually not a URL; rather, it’s a local file path where your trusted certificates are stored. | |
| *Format:* The CA Pool option typically expects a path to a certificate store file or a bundle file in .pem or .crt format. This file should contain one or more trusted root CA certificates. It's usually not a URL; rather, it's a local file path where your trusted certificates are stored. |
Issues:
- Style Guide - (cloudflare.NonStandardQuotes-warning) Use standard single quotes or double quotes only. Do not use any of the following quote mark types: ‘ ’ “ ”. In the text, we found this character: ’
- Style Guide - (cloudflare.NonStandardQuotes-warning) Use standard single quotes or double quotes only. Do not use any of the following quote mark types: ‘ ’ “ ”. In the text, we found this character: ’
Fix Explanation:
The issue is with the non-standard quote mark ’ used in the word 'It's'. Replacing it with a standard single quote (') resolves the style guide violation.
| | ------- | -------------------------- | | ||
| | `""` | Certificate Authority Pool | | ||
|
|
||
| Path to the certificate authority (CA) for the certificate of your origin. This option should be used only if your certificate is not signed by Cloudflare. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dledfordcf, what would be an example of a typical input value? /root/certs/ca.pem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do believe so, but I will admit I'm not 100% sure as I havent had a chance to lab this. Janani or maybe Kenny might know for sure the exact way that its supposed to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janani-cr or @DevinCarr, would you mind checking this PR?
|
Congratulations @dledfordcf, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm3ol4l2y155330cl7vdsm5lxa This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
* Adding information to format of caPool option The current information for the caPool option is a bit vauge on what to actually enter here. Added information provided by another CF Employee to the doc. * Update origin-configuration.mdx --------- Co-authored-by: ranbel <[email protected]>
The current information for the caPool option is a bit vauge on what to actually enter here.
Added information provided by another CF Employee to the doc.
Summary
Added this line "Format: The CA Pool option typically expects a path to a certificate store file or a bundle file in .pem or .crt format. This file should contain one or more trusted root CA certificates. It’s usually not a URL; rather, it’s a local file path where your trusted certificates are stored."
Screenshots (optional)
Documentation checklist