Skip to content

Conversation

@dledfordcf
Copy link
Contributor

The current information for the caPool option is a bit vauge on what to actually enter here.

Added information provided by another CF Employee to the doc.

Summary

Added this line "Format: The CA Pool option typically expects a path to a certificate store file or a bundle file in .pem or .crt format. This file should contain one or more trusted root CA certificates. It’s usually not a URL; rather, it’s a local file path where your trusted certificates are stored."

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

The current information for the caPool option is a bit vauge on what to actually enter here.

Added information provided by another CF Employee to the doc.
@dledfordcf dledfordcf requested review from a team, janani-cr and ranbel as code owners October 30, 2024 00:22
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 files reviewed, 1 total issue(s) found.


Path to the certificate authority (CA) for the certificate of your origin. This option should be used only if your certificate is not signed by Cloudflare.

*Format:* The CA Pool option typically expects a path to a certificate store file or a bundle file in .pem or .crt format. This file should contain one or more trusted root CA certificates. It’s usually not a URL; rather, it’s a local file path where your trusted certificates are stored.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*Format:* The CA Pool option typically expects a path to a certificate store file or a bundle file in .pem or .crt format. This file should contain one or more trusted root CA certificates. Its usually not a URL; rather, its a local file path where your trusted certificates are stored.
*Format:* The CA Pool option typically expects a path to a certificate store file or a bundle file in .pem or .crt format. This file should contain one or more trusted root CA certificates. It's usually not a URL; rather, it's a local file path where your trusted certificates are stored.

Issues:

  • Style Guide - (cloudflare.NonStandardQuotes-warning) Use standard single quotes or double quotes only. Do not use any of the following quote mark types: ‘ ’ “ ”. In the text, we found this character: ’
  • Style Guide - (cloudflare.NonStandardQuotes-warning) Use standard single quotes or double quotes only. Do not use any of the following quote mark types: ‘ ’ “ ”. In the text, we found this character: ’

Fix Explanation:

The issue is with the non-standard quote mark ’ used in the word 'It's'. Replacing it with a standard single quote (') resolves the style guide violation.

| ------- | -------------------------- |
| `""` | Certificate Authority Pool |

Path to the certificate authority (CA) for the certificate of your origin. This option should be used only if your certificate is not signed by Cloudflare.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dledfordcf, what would be an example of a typical input value? /root/certs/ca.pem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do believe so, but I will admit I'm not 100% sure as I havent had a chance to lab this. Janani or maybe Kenny might know for sure the exact way that its supposed to work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janani-cr or @DevinCarr, would you mind checking this PR?

@ranbel ranbel merged commit 7028ca4 into cloudflare:production Nov 19, 2024
7 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Nov 19, 2024
@holopin-bot
Copy link

holopin-bot bot commented Nov 19, 2024

Congratulations @dledfordcf, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm3ol4l2y155330cl7vdsm5lxa

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

harshil1712 pushed a commit that referenced this pull request Dec 3, 2024
* Adding information to format of caPool option

The current information for the caPool option is a bit vauge on what to actually enter here.

Added information provided by another CF Employee to the doc.

* Update origin-configuration.mdx

---------

Co-authored-by: ranbel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution [Holopin] Recognizes a docs contribution, big or small product:cloudflare-one size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants