Skip to content

Adding information to format of caPool option #17867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Adding information to format of caPool option #17867

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b13d691
Adding information to format of caPool option
dledfordcf Oct 30, 2024
8e48761
Update origin-configuration.mdx
ranbel Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...are-one/connections/connect-networks/configure-tunnels/origin-configuration.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ Hostname that `cloudflared` should expect from your origin server certificate. I

Path to the certificate authority (CA) for the certificate of your origin. This option should be used only if your certificate is not signed by Cloudflare.
Copy link
Contributor

@ranbel ranbel Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dledfordcf, what would be an example of a typical input value? /root/certs/ca.pem?

Copy link
Contributor Author

@dledfordcf dledfordcf Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do believe so, but I will admit I'm not 100% sure as I havent had a chance to lab this. Janani or maybe Kenny might know for sure the exact way that its supposed to work?

Copy link
Contributor

@ranbel ranbel Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janani-cr or @DevinCarr, would you mind checking this PR?


*Format:* The CA Pool option typically expects a path to a certificate store file or a bundle file in .pem or .crt format. This file should contain one or more trusted root CA certificates. It’s usually not a URL; rather, it’s a local file path where your trusted certificates are stored.
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*Format:* The CA Pool option typically expects a path to a certificate store file or a bundle file in .pem or .crt format. This file should contain one or more trusted root CA certificates. It’s usually not a URL; rather, it’s a local file path where your trusted certificates are stored.
*Format:* The CA Pool option typically expects a path to a certificate store file or a bundle file in .pem or .crt format. This file should contain one or more trusted root CA certificates. It's usually not a URL; rather, it's a local file path where your trusted certificates are stored.

Issues:

  • Style Guide - (cloudflare.NonStandardQuotes-warning) Use standard single quotes or double quotes only. Do not use any of the following quote mark types: ‘ ’ “ ”. In the text, we found this character: ’
  • Style Guide - (cloudflare.NonStandardQuotes-warning) Use standard single quotes or double quotes only. Do not use any of the following quote mark types: ‘ ’ “ ”. In the text, we found this character: ’

Fix Explanation:

The issue is with the non-standard quote mark ’ used in the word 'It's'. Replacing it with a standard single quote (') resolves the style guide violation.


### noTLSVerify

| Default | UI name |
Expand Down
Loading