Skip to content

Conversation

@RebeccaTamachiro
Copy link
Contributor

Summary

PCX-14273

Documentation checklist

@github-actions github-actions bot added size/s product:ssl Related to SSL labels Nov 14, 2024
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 14, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 49f5b90
Status: ✅  Deploy successful!
Preview URL: https://82ee61db.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://rebecca-ssl-post-quantum-cry.cloudflare-docs-7ou.pages.dev

View logs

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 total issue(s) found.

@github-actions github-actions bot added size/m and removed size/s labels Nov 18, 2024
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 total issue(s) found.

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Copy link
Contributor

@lukevalenta lukevalenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but looking good so far! I haven't yet reviewed the pqc-to-origin docs.

@RebeccaTamachiro RebeccaTamachiro marked this pull request as ready for review November 21, 2024 12:56
@RebeccaTamachiro RebeccaTamachiro requested a review from a team as a code owner November 21, 2024 12:56
Copy link
Contributor

@lukevalenta lukevalenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@RebeccaTamachiro RebeccaTamachiro enabled auto-merge (squash) November 22, 2024 15:27
Copy link
Contributor

@SulemanAhmadd SulemanAhmadd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes. LGTM!

@RebeccaTamachiro RebeccaTamachiro merged commit e68adcf into production Nov 22, 2024
12 checks passed
@RebeccaTamachiro RebeccaTamachiro deleted the rebecca/ssl-post-quantum-cryptography branch November 22, 2024 15:54
harshil1712 pushed a commit that referenced this pull request Dec 3, 2024
* Add placeholders for new folder and pages and fill in frontmatter

* Add outline for index.mdx and fill in TLS background info

* Apply suggestion: Reword intro to TLS building blocks

Co-authored-by: Peter Wu <[email protected]>

* Fix typo and reword index.mdx meta description

* Improve parallelism, refine text, and link out to TLS handshake LC

* Fill in hybrid key agreement section

* Complete visitor-to-cloudflare intro paragraph

* Add mermaid digram for connections and reword #2

* Fix Internet capitalization

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>

* Rename file, fill in, and link to pqc-support

* Fix capitalization and fill in Intenal connections section

* Fill in Cf to origin and review titles and headings

* Fix missing hyphen and touch up pqc-to-origin description

* Add split ClientHello and HRR workaround to pqc-to-origin

* Add setup instructions to pqc-to-origin

* Apply suggestion from code review

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Luke Valenta <[email protected]>
Co-authored-by: Suleman Ahmad <[email protected]>

* Replace store by harvest, adjust RFC link cf Style Guide, and split long paragarph

* Add reference to PQ signatures and link out to blog

* Fix origin server section to use fork and bssl for both cases

* Add link to Cloudflare Radar

Co-authored-by: Luke Valenta <[email protected]>

* Text review and move link to Radar higher up in the page

* Simplify origin server instructions to use BoringSSL instead of fork

Co-authored-by: Suleman Ahmad <[email protected]>

* Overall text review and remove previous origin instructions

* Apply suggestion from code review

Co-authored-by: Jun Lee <[email protected]>

---------

Co-authored-by: Peter Wu <[email protected]>
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Co-authored-by: Luke Valenta <[email protected]>
Co-authored-by: Suleman Ahmad <[email protected]>
Co-authored-by: Jun Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:ssl Related to SSL size/m

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants