-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[SSL/TLS] Bring in PQC content to Dev Docs #18165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SSL/TLS] Bring in PQC content to Dev Docs #18165
Conversation
Deploying cloudflare-docs with
|
| Latest commit: |
49f5b90
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://82ee61db.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://rebecca-ssl-post-quantum-cry.cloudflare-docs-7ou.pages.dev |
Co-authored-by: Peter Wu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 total issue(s) found.
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 total issue(s) found.
src/content/docs/ssl/post-quantum-cryptography/pqc-to-origin.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
lukevalenta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, but looking good so far! I haven't yet reviewed the pqc-to-origin docs.
src/content/docs/ssl/post-quantum-cryptography/pqc-to-origin.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/ssl/post-quantum-cryptography/pqc-to-origin.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/ssl/post-quantum-cryptography/pqc-to-origin.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/ssl/post-quantum-cryptography/pqc-to-origin.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/ssl/post-quantum-cryptography/pqc-to-origin.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Luke Valenta <[email protected]> Co-authored-by: Suleman Ahmad <[email protected]>
lukevalenta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
src/content/docs/ssl/post-quantum-cryptography/pqc-to-origin.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/ssl/post-quantum-cryptography/pqc-to-origin.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jun Lee <[email protected]>
SulemanAhmadd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the changes. LGTM!
* Add placeholders for new folder and pages and fill in frontmatter * Add outline for index.mdx and fill in TLS background info * Apply suggestion: Reword intro to TLS building blocks Co-authored-by: Peter Wu <[email protected]> * Fix typo and reword index.mdx meta description * Improve parallelism, refine text, and link out to TLS handshake LC * Fill in hybrid key agreement section * Complete visitor-to-cloudflare intro paragraph * Add mermaid digram for connections and reword #2 * Fix Internet capitalization Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com> * Rename file, fill in, and link to pqc-support * Fix capitalization and fill in Intenal connections section * Fill in Cf to origin and review titles and headings * Fix missing hyphen and touch up pqc-to-origin description * Add split ClientHello and HRR workaround to pqc-to-origin * Add setup instructions to pqc-to-origin * Apply suggestion from code review Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Luke Valenta <[email protected]> Co-authored-by: Suleman Ahmad <[email protected]> * Replace store by harvest, adjust RFC link cf Style Guide, and split long paragarph * Add reference to PQ signatures and link out to blog * Fix origin server section to use fork and bssl for both cases * Add link to Cloudflare Radar Co-authored-by: Luke Valenta <[email protected]> * Text review and move link to Radar higher up in the page * Simplify origin server instructions to use BoringSSL instead of fork Co-authored-by: Suleman Ahmad <[email protected]> * Overall text review and remove previous origin instructions * Apply suggestion from code review Co-authored-by: Jun Lee <[email protected]> --------- Co-authored-by: Peter Wu <[email protected]> Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com> Co-authored-by: Luke Valenta <[email protected]> Co-authored-by: Suleman Ahmad <[email protected]> Co-authored-by: Jun Lee <[email protected]>
Summary
PCX-14273
Documentation checklist