[Logs] Adds update job name #18829
Merged
[Logs] Adds update job name #18829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelampcosta
requested review from
a team,
bharatnc,
cmackenzie1,
jherre,
soheiokamoto and
victor-perov
as code owners
Deploying cloudflare-docs with
|
| Latest commit: |
34d6b82
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://db837eae.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://angela-update-job-name-api.cloudflare-docs-7ou.pages.dev |
Contributor
|
Files with changes (up to 15)
|
marciocloudflare
approved these changes
Dec 18, 2024
| | `GET` | Retrieve all jobs for a dataset | [Documentation](/api/resources/logpush/subresources/datasets/subresources/jobs/methods/get/) | | ||
| | `GET` | Retrieve all available fields for a dataset | [Documentation](/api/resources/logpush/subresources/datasets/subresources/fields/methods/get/) | | ||
| | `PUT` | Update job | [Documentation](/api/resources/logpush/subresources/jobs/methods/update/) | | ||
| | `PUT` | Update job name. | [Documentation](/api/resources/logpush/subresources/jobs/methods/update/) | |
Contributor
There was a problem hiding this comment.
This is not a separate endpoint, and I don't think it should have been added like this.
We just made name field to be updatable in Update job endpoint.
It would be more appropriate to add a section below to describe briefly what this field is for (mainly for a user to set a descriptive name for a job to make it easier to find / identify their jobs).
Contributor
Author
There was a problem hiding this comment.
Thanks @soheiokamoto I've opened another PR to address your comment #18857
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds update job name option.
Documentation checklist