Skip to content

[Logs] Adds update job name #18829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2024
Merged

[Logs] Adds update job name #18829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/content/docs/logs/get-started/api-configuration.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ The `{dataset_id}` argument indicates the log category (such as `http_requests`
| `GET` | Retrieve all jobs for a dataset | [Documentation](/api/resources/logpush/subresources/datasets/subresources/jobs/methods/get/) |
| `GET` | Retrieve all available fields for a dataset | [Documentation](/api/resources/logpush/subresources/datasets/subresources/fields/methods/get/) |
| `PUT` | Update job | [Documentation](/api/resources/logpush/subresources/jobs/methods/update/) |
| `PUT` | Update job name. | [Documentation](/api/resources/logpush/subresources/jobs/methods/update/) |
Copy link
Contributor

@soheiokamoto soheiokamoto Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a separate endpoint, and I don't think it should have been added like this.
We just made name field to be updatable in Update job endpoint.

It would be more appropriate to add a section below to describe briefly what this field is for (mainly for a user to set a descriptive name for a job to make it easier to find / identify their jobs).

Copy link
Contributor Author

@angelampcosta angelampcosta Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @soheiokamoto I've opened another PR to address your comment #18857

| `DELETE` | Delete job | [Documentation](/api/resources/logpush/subresources/jobs/methods/delete/) |
| `POST` | Check whether destination exists | [Documentation](/api/resources/logpush/subresources/validate/methods/destination/) |
| `POST` | Get ownership challenge | [Documentation](/api/resources/logpush/subresources/ownership/methods/validate/) |
Expand Down
Loading