-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Hyperlint Automation: Broken Link Fixes #19685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| :::note | ||
|
|
||
| You can also use RPC to communicate between Workers and [Durable Objects](/durable-objects/best-practices/create-durable-object-stubs-and-send-requests/#call-rpc-methods). | ||
| You can also use RPC to communicate between Workers and [Durable Objects](/durable-objects/best-practices/create-durable-object-stubs-and-send-requests/#invoke-rpc-methods). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page: http://localhost:1111/workers/runtime-apis/bindings/service-bindings/rpc/
has a broken internal link to: http://localhost:1111/durable-objects/best-practices/create-durable-object-stubs-and-send-requests/.
The fragment call-rpc-methods does not exist.
By looking at the page: http://localhost:1111/durable-objects/best-practices/create-durable-object-stubs-and-send-requests/
The best fragment to use seems to be: #invoke-rpc-methods
| #### Remove Cloudflare access to the entire GitHub account | ||
|
|
||
| To remove Cloudflare Workers and Pages access to your entire Git account, you can navigate to **Uninstall "Cloudflare Workers and Pages"**, then select **Uninstall**. Removing access to the Cloudflare Workers and Pages app will revoke Cloudflare's access to _all repositories_ from that GitHub account. If you want to only disable automatic builds and deployments, follow the [Disable Build](/workers/ci-cd/builds/#disabling-builds) instructions. | ||
| To remove Cloudflare Workers and Pages access to your entire Git account, you can navigate to **Uninstall "Cloudflare Workers and Pages"**, then select **Uninstall**. Removing access to the Cloudflare Workers and Pages app will revoke Cloudflare's access to _all repositories_ from that GitHub account. If you want to only disable automatic builds and deployments, follow the [Disable Build](/workers/ci-cd/builds/#disconnecting-builds) instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page: http://localhost:1111/workers/ci-cd/builds/git-integration/github-integration/
has a broken internal link to: http://localhost:1111/workers/ci-cd/builds/.
The fragment disabling-builds does not exist.
By looking at the page: http://localhost:1111/workers/ci-cd/builds/
The best fragment to use seems to be: #disconnecting-builds
| #### Remove Cloudflare access to the entire GitHub account | ||
|
|
||
| To remove Cloudflare Workers and Pages access to your entire Git account, you can navigate to **Uninstall "Cloudflare Workers and Pages"**, then select **Uninstall**. Removing access to the Cloudflare Workers and Pages app will revoke Cloudflare's access to _all repositories_ from that GitHub account. If you want to only disable automatic builds and deployments, follow the [Disable Build](/workers/ci-cd/builds/#disabling-builds) instructions. | ||
| To remove Cloudflare Workers and Pages access to your entire Git account, you can navigate to **Uninstall "Cloudflare Workers and Pages"**, then select **Uninstall**. Removing access to the Cloudflare Workers and Pages app will revoke Cloudflare's access to _all repositories_ from that GitHub account. If you want to only disable automatic builds and deployments, follow the [Disable Build](/workers/ci-cd/builds/#disconnecting-builds) instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page: http://localhost:1111/workers/ci-cd/builds/git-integration/github-integration/
has a broken internal link to: http://localhost:1111/workers/ci-cd/builds/.
The fragment disabling-builds does not exist.
By looking at the page: http://localhost:1111/workers/ci-cd/builds/
The best fragment to use seems to be: #disconnecting-builds
| - Make sure that your Worker is developed using the ES modules format. To migrate from the service worker format to the ES modules format, refer to the [Migrate to the ES modules format](/workers/reference/migrate-to-module-workers/) guide. | ||
|
|
||
| - In your project's `wrangler.toml / wrangler.json` file, define a [compatibility date](/workers/configuration/compatibility-dates/) of `2022-10-31` or higher, and include `nodejs_compat` in your [compatibility flags](/workers/wrangler/configuration/#use-runtime-apis-directly). | ||
| - In your project's `wrangler.toml / wrangler.json` file, define a [compatibility date](/workers/configuration/compatibility-dates/) of `2022-10-31` or higher, and include `nodejs_compat` in your [compatibility flags](/workers/wrangler/configuration/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page: http://localhost:1111/workers/testing/vitest-integration/get-started/write-your-first-test/
has a broken internal link to: http://localhost:1111/workers/wrangler/configuration/.
The fragment use-runtime-apis-directly does not exist.
By looking at the page: http://localhost:1111/workers/wrangler/configuration/
There was no ideal replacement found and so we removed the header link.
| ## Other Cloudflare APIs (`cf`, `ctx`) | ||
|
|
||
| Access context about the incoming request from the [`cf` object](/workers/runtime-apis/request/#incomingrequestcfproperties), as well as [lifecycle methods from the `ctx` object](/workers/runtime-apis/handlers/fetch/#lifecycle-methods) from the return value of [`getRequestContext()`](https://github.com/cloudflare/next-on-pages/blob/main/packages/next-on-pages/src/api/getRequestContext.ts): | ||
| Access context about the incoming request from the [`cf` object](/workers/runtime-apis/request/#incomingrequestcfproperties), as well as [lifecycle methods from the `ctx` object](/workers/runtime-apis/handlers/fetch/) from the return value of [`getRequestContext()`](https://github.com/cloudflare/next-on-pages/blob/main/packages/next-on-pages/src/api/getRequestContext.ts): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page: http://localhost:1111/pages/framework-guides/nextjs/ssr/bindings/
has a broken internal link to: http://localhost:1111/workers/runtime-apis/handlers/fetch/.
The fragment lifecycle-methods does not exist.
By looking at the page: http://localhost:1111/workers/runtime-apis/handlers/fetch/
There was no ideal replacement found and so we removed the header link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kodster28
Feedback on this one > I don't know enough about this subject and would have to ask someone to know for sure if this is the correct link. I believe the suggestion it's making is based on where the page is currently redirecting to. Let me know if you would want me to track down someone else to approve it in a case like this next time or if that added effort is defeating the purpose of these kinds of PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely not worth the added effort.
The idea here is a general best guess based on your knowledge of the docs.
cc: @bllchmbrs, just in case there's anything worth noting here.
Deploying cloudflare-docs with
|
| Latest commit: |
599f8d4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ce8b8a9a.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://hyperlint-scan-broken-link-3-tyj6.cloudflare-docs-7ou.pages.dev |
src/content/docs/workers/testing/vitest-integration/get-started/write-your-first-test.mdx
Outdated
Show resolved
Hide resolved
| ## Other Cloudflare APIs (`cf`, `ctx`) | ||
|
|
||
| Access context about the incoming request from the [`cf` object](/workers/runtime-apis/request/#incomingrequestcfproperties), as well as [lifecycle methods from the `ctx` object](/workers/runtime-apis/handlers/fetch/#lifecycle-methods) from the return value of [`getRequestContext()`](https://github.com/cloudflare/next-on-pages/blob/main/packages/next-on-pages/src/api/getRequestContext.ts): | ||
| Access context about the incoming request from the [`cf` object](/workers/runtime-apis/request/#incomingrequestcfproperties), as well as [lifecycle methods from the `ctx` object](/workers/runtime-apis/handlers/fetch/) from the return value of [`getRequestContext()`](https://github.com/cloudflare/next-on-pages/blob/main/packages/next-on-pages/src/api/getRequestContext.ts): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kodster28
Feedback on this one > I don't know enough about this subject and would have to ask someone to know for sure if this is the correct link. I believe the suggestion it's making is based on where the page is currently redirecting to. Let me know if you would want me to track down someone else to approve it in a case like this next time or if that added effort is defeating the purpose of these kinds of PRs.
…d/write-your-first-test.mdx
|
Congratulations @Hyperlint-AI[bot], the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm6rvuybg178420ci296wdi9gv This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Broken Link Fix Proposal(s)
The goal of this pull request is to fix broken links in the documentation.
Proposing changes to the following files:
to edit this branch locally, run:
🗣️Leave us feedback
This pull request is part of a series of Hyperlint Automations to ease the burden of maintaining documentation.
We'll be introducing this automation, and others, over the coming months. These automations will always open pull requests(or issues) prior to making changes.
If this is not the change you want, please close this pull request and let us know what you'd like to see.
This feature may introduce erroneous changes (although we work hard to make sure that doesn't happen). Please review the changes before merging.
❌ Limitations:
At this time, Hyperlint can't respond to pull requests or issues.
📩 Need Help?
Please reach out to support with any requests, questions, or concerns.