Skip to content

Hyperlint Automation: Broken Link Fixes #19685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Hyperlint Automation: Broken Link Fixes #19685

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d65a8b5
Fix issue: WorkspaceTaskSubType.BROKEN_LINK
hyperlint-ai[bot] Feb 3, 2025
210f3af
Fix issue: WorkspaceTaskSubType.BROKEN_LINK
hyperlint-ai[bot] Feb 3, 2025
8cf32b0
Fix issue: WorkspaceTaskSubType.BROKEN_LINK
hyperlint-ai[bot] Feb 3, 2025
33febe4
Fix issue: WorkspaceTaskSubType.BROKEN_LINK
hyperlint-ai[bot] Feb 3, 2025
4f68902
Fix issue: WorkspaceTaskSubType.BROKEN_LINK
hyperlint-ai[bot] Feb 3, 2025
599f8d4
Update src/content/docs/workers/testing/vitest-integration/get-starte…
ToriLindsay Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/content/docs/pages/configuration/git-integration/github-integration.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ To remove access to an individual GitHub repository, you can navigate to **Repos

#### Remove Cloudflare access to the entire GitHub account

To remove Cloudflare Workers and Pages access to your entire Git account, you can navigate to **Uninstall "Cloudflare Workers and Pages"**, then select **Uninstall**. Removing access to the Cloudflare Workers and Pages app will revoke Cloudflare's access to _all repositories_ from that GitHub account. If you want to only disable automatic builds and deployments, follow the [Disable Build](/workers/ci-cd/builds/#disabling-builds) instructions.
To remove Cloudflare Workers and Pages access to your entire Git account, you can navigate to **Uninstall "Cloudflare Workers and Pages"**, then select **Uninstall**. Removing access to the Cloudflare Workers and Pages app will revoke Cloudflare's access to _all repositories_ from that GitHub account. If you want to only disable automatic builds and deployments, follow the [Disable Build](/workers/ci-cd/builds/#disconnecting-builds) instructions.
Copy link
Contributor Author

@hyperlint-ai hyperlint-ai bot Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page: http://localhost:1111/workers/ci-cd/builds/git-integration/github-integration/
has a broken internal link to: http://localhost:1111/workers/ci-cd/builds/.
The fragment disabling-builds does not exist.

By looking at the page: http://localhost:1111/workers/ci-cd/builds/
The best fragment to use seems to be: #disconnecting-builds


Note that removing access to GitHub will disable new builds for Workers and Pages project that were connected to those repositories, though your previous deployments will continue to be hosted by Cloudflare Workers.

Expand Down
2 changes: 1 addition & 1 deletion src/content/docs/pages/framework-guides/nextjs/ssr/bindings.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ interface CloudflareEnv {

## Other Cloudflare APIs (`cf`, `ctx`)

Access context about the incoming request from the [`cf` object](/workers/runtime-apis/request/#incomingrequestcfproperties), as well as [lifecycle methods from the `ctx` object](/workers/runtime-apis/handlers/fetch/#lifecycle-methods) from the return value of [`getRequestContext()`](https://github.com/cloudflare/next-on-pages/blob/main/packages/next-on-pages/src/api/getRequestContext.ts):
Access context about the incoming request from the [`cf` object](/workers/runtime-apis/request/#incomingrequestcfproperties), as well as [lifecycle methods from the `ctx` object](/workers/runtime-apis/handlers/fetch/) from the return value of [`getRequestContext()`](https://github.com/cloudflare/next-on-pages/blob/main/packages/next-on-pages/src/api/getRequestContext.ts):
Copy link
Contributor Author

@hyperlint-ai hyperlint-ai bot Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page: http://localhost:1111/pages/framework-guides/nextjs/ssr/bindings/
has a broken internal link to: http://localhost:1111/workers/runtime-apis/handlers/fetch/.
The fragment lifecycle-methods does not exist.

By looking at the page: http://localhost:1111/workers/runtime-apis/handlers/fetch/
There was no ideal replacement found and so we removed the header link.

Copy link
Contributor

@ToriLindsay ToriLindsay Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kodster28
Feedback on this one > I don't know enough about this subject and would have to ask someone to know for sure if this is the correct link. I believe the suggestion it's making is based on where the page is currently redirecting to. Let me know if you would want me to track down someone else to approve it in a case like this next time or if that added effort is defeating the purpose of these kinds of PRs.

Copy link
Collaborator

@kodster28 kodster28 Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely not worth the added effort.

The idea here is a general best guess based on your knowledge of the docs.

cc: @bllchmbrs, just in case there's anything worth noting here.


```js
import { getRequestContext } from "@cloudflare/next-on-pages";
Expand Down
2 changes: 1 addition & 1 deletion src/content/docs/workers/ci-cd/builds/git-integration/github-integration.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ To remove access to an individual GitHub repository, you can navigate to **Repos

#### Remove Cloudflare access to the entire GitHub account

To remove Cloudflare Workers and Pages access to your entire Git account, you can navigate to **Uninstall "Cloudflare Workers and Pages"**, then select **Uninstall**. Removing access to the Cloudflare Workers and Pages app will revoke Cloudflare's access to _all repositories_ from that GitHub account. If you want to only disable automatic builds and deployments, follow the [Disable Build](/workers/ci-cd/builds/#disabling-builds) instructions.
To remove Cloudflare Workers and Pages access to your entire Git account, you can navigate to **Uninstall "Cloudflare Workers and Pages"**, then select **Uninstall**. Removing access to the Cloudflare Workers and Pages app will revoke Cloudflare's access to _all repositories_ from that GitHub account. If you want to only disable automatic builds and deployments, follow the [Disable Build](/workers/ci-cd/builds/#disconnecting-builds) instructions.
Copy link
Contributor Author

@hyperlint-ai hyperlint-ai bot Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page: http://localhost:1111/workers/ci-cd/builds/git-integration/github-integration/
has a broken internal link to: http://localhost:1111/workers/ci-cd/builds/.
The fragment disabling-builds does not exist.

By looking at the page: http://localhost:1111/workers/ci-cd/builds/
The best fragment to use seems to be: #disconnecting-builds


Note that removing access to GitHub will disable new builds for Workers and Pages project that were connected to those repositories, though your previous deployments will continue to be hosted by Cloudflare Workers.

Expand Down
2 changes: 1 addition & 1 deletion src/content/docs/workers/runtime-apis/bindings/service-bindings/rpc.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The [RPC system in Workers](/workers/runtime-apis/rpc) is designed feel as simil

:::note

You can also use RPC to communicate between Workers and [Durable Objects](/durable-objects/best-practices/create-durable-object-stubs-and-send-requests/#call-rpc-methods).
You can also use RPC to communicate between Workers and [Durable Objects](/durable-objects/best-practices/create-durable-object-stubs-and-send-requests/#invoke-rpc-methods).
Copy link
Contributor Author

@hyperlint-ai hyperlint-ai bot Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page: http://localhost:1111/workers/runtime-apis/bindings/service-bindings/rpc/
has a broken internal link to: http://localhost:1111/durable-objects/best-practices/create-durable-object-stubs-and-send-requests/.
The fragment call-rpc-methods does not exist.

By looking at the page: http://localhost:1111/durable-objects/best-practices/create-durable-object-stubs-and-send-requests/
The best fragment to use seems to be: #invoke-rpc-methods

:::

## Example
Expand Down
2 changes: 1 addition & 1 deletion ...t/docs/workers/testing/vitest-integration/get-started/write-your-first-test.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ This guide will instruct you through installing and setting up the `@cloudflare/

- Make sure that your Worker is developed using the ES modules format. To migrate from the service worker format to the ES modules format, refer to the [Migrate to the ES modules format](/workers/reference/migrate-to-module-workers/) guide.

- In your project's `wrangler.toml / wrangler.json` file, define a [compatibility date](/workers/configuration/compatibility-dates/) of `2022-10-31` or higher, and include `nodejs_compat` in your [compatibility flags](/workers/wrangler/configuration/#use-runtime-apis-directly).
- In your project's `wrangler.toml / wrangler.json` file, define a [compatibility date](/workers/configuration/compatibility-dates/) of `2022-10-31` or higher, and include `nodejs_compat` in your [compatibility flags](/workers/wrangler/configuration/).
Copy link
Contributor Author

@hyperlint-ai hyperlint-ai bot Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page: http://localhost:1111/workers/testing/vitest-integration/get-started/write-your-first-test/
has a broken internal link to: http://localhost:1111/workers/wrangler/configuration/.
The fragment use-runtime-apis-directly does not exist.

By looking at the page: http://localhost:1111/workers/wrangler/configuration/
There was no ideal replacement found and so we removed the header link.


## Install Vitest and `@cloudflare/vitest-pool-workers`

Expand Down