Skip to content

Conversation

@kodster28
Copy link
Collaborator

Summary

@bllchmbrs, question... does the custom_comment access \n characters? And/or, does it accept markdown input as well?

@github-actions
Copy link
Contributor

Howdy and thanks for contributing to our repo. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025

@bllchmbrs
Copy link
Contributor

@kodster28 , will take a look at this a bit later this AM and make sure you're all good! I believe the multi-line yaml should just work!

@bllchmbrs
Copy link
Contributor

bllchmbrs commented Mar 10, 2025

@kodster28 , just copy and paste this:

content_dir: /src/content
reviewer:
  custom_comment: |-
    Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within **two (2) weeks**. If it's been two weeks or longer without any movement, please tag the PR **Assignees** in a comment.

    We review internal PRs within **1 week**. If it's something urgent or has been sitting without a comment, start a thread in the *Developer Docs* space internally.
  enabled: true
  external_link_validation:
    check_status_upon_review_failure: neutral
  summarize_pull_request:
    enabled: true
  vale_style_guide:
    check_status_upon_review_failure: neutral
    enabled: true

That respects multi-line for your 'preamble' comment. I did edit it for a bit of clarity (old writing habits die hard 😉)

I also changed the check status to neutral on failure. It won't "bark" like the ❌ but it still provides a subtle note for the observant.

@kodster28
Copy link
Collaborator Author

Howd

@kodster28 , just copy and paste this:

content_dir: /src/content
reviewer:
  custom_comment: |-
    Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within **two (2) weeks**. If it's been two weeks or longer without any movement, please tag the PR **Assignees** in a comment.

    We review internal PRs within **1 week**. If it's something urgent or has been sitting without a comment, start a thread in the *Developer Docs* space internally.
  enabled: true
  external_link_validation:
    check_status_upon_review_failure: neutral
  summarize_pull_request:
    enabled: true
  vale_style_guide:
    check_status_upon_review_failure: neutral
    enabled: true

That respects multi-line for your 'preamble' comment. I did edit it for a bit of clarity (old writing habits die hard 😉)

I also changed the check status to neutral on failure. It won't "bark" like the ❌ but it still provides a subtle note for the observant.

Okay, Adjusted but didn't know if we still needed the openapi + authorized_users separately

@bllchmbrs
Copy link
Contributor

you can leave them, or remove them, they are ignored at this point!

@kodster28 kodster28 enabled auto-merge (squash) March 11, 2025 13:31
@kodster28 kodster28 merged commit 961e0d2 into production Mar 11, 2025
9 checks passed
@kodster28 kodster28 deleted the hyperlint-config-2 branch March 11, 2025 13:34
RebeccaTamachiro pushed a commit that referenced this pull request Apr 21, 2025
* [Hyperlint] Adjust settings

* Custom review message

* Remove comment from PR check

* Revised

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants