-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Add additional info for worker service binding rpc example #20882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional info for worker service binding rpc example #20882
Conversation
src/content/docs/workers/runtime-apis/bindings/service-bindings/index.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/runtime-apis/bindings/service-bindings/index.mdx
Outdated
Show resolved
Hide resolved
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryEnhanced the RPC example for service binding by adding additional context and clarifications.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add What is Hyperlint?Hyperlint is an AI agent that helps you write, edit, and maintain your documentation. Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation. |
src/content/docs/workers/runtime-apis/bindings/service-bindings/index.mdx
Outdated
Show resolved
Hide resolved
|
Hi @GregBrimble - Would you mind reviewing this one to see if I'm adding accurate, helpful context? (I just made my best guess). Thank you! |
GregBrimble
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think RPC does also kinda work without using the WorkerEntrypoint class (we recently went on an exploration for this here), but it is a much better when using WorkerEntrypoint, so I'm more than happy to push that here in the docs.
* Add additional info for worker service binding rpc example * Update src/content/docs/workers/runtime-apis/bindings/service-bindings/index.mdx * Update src/content/docs/workers/runtime-apis/bindings/service-bindings/index.mdx
Fixes #17421
The main issue raised in #17421 was the lack of
defaultwhich was fixed by #18163 . So, I think the only thing left to do is to add some additional context for the example.