Skip to content

Conversation

@ToriLindsay
Copy link
Contributor

Fixes #17421
The main issue raised in #17421 was the lack of default which was fixed by #18163 . So, I think the only thing left to do is to add some additional context for the example.

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Mar 17, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Enhanced the RPC example for service binding by adding additional context and clarifications.

  • Added context for the RPC-based Service bindings example
  • Clarified the usage of the WorkerEntrypoint class in the example
  • Updated the example to improve understanding of service binding communication

Modified Files

  • src/content/docs/workers/runtime-apis/bindings/service-bindings/index.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

What is Hyperlint?

Hyperlint is an AI agent that helps you write, edit, and maintain your documentation.

Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation.

@github-actions github-actions bot added product:workers Related to Workers product size/xs labels Mar 17, 2025
@ToriLindsay
Copy link
Contributor Author

Hi @GregBrimble - Would you mind reviewing this one to see if I'm adding accurate, helpful context? (I just made my best guess). Thank you!

Copy link
Contributor

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think RPC does also kinda work without using the WorkerEntrypoint class (we recently went on an exploration for this here), but it is a much better when using WorkerEntrypoint, so I'm more than happy to push that here in the docs.

@ToriLindsay ToriLindsay merged commit cef52d0 into production Mar 24, 2025
11 checks passed
@ToriLindsay ToriLindsay deleted the tori/pcx17421-add-service-workers-link-from-service-bindings branch March 24, 2025 09:25
RebeccaTamachiro pushed a commit that referenced this pull request Apr 21, 2025
* Add additional info for worker service binding rpc example

* Update src/content/docs/workers/runtime-apis/bindings/service-bindings/index.mdx

* Update src/content/docs/workers/runtime-apis/bindings/service-bindings/index.mdx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workers Related to Workers product size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Worker service-binding using RPC example incomplete

5 participants