[SSL] Add missing features and fix formatting for cert limits #21016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrosousa
reviewed
Mar 21, 2025
Contributor
|
Preview URL: https://ebe27eea.preview.developers.cloudflare.com |
pedrosousa
approved these changes
Mar 21, 2025
| "pro_plus": 1, | ||
| "free": "0", | ||
| "pro": "0", | ||
| "pro_plus": "1", |
Contributor
There was a problem hiding this comment.
Nit: There's something strange here, because in the plans page we're not getting the "Pro Plus" label, only the value:
Maybe it's an issue in the Plans page itself.
Contributor
Author
There was a problem hiding this comment.
Uh, weird. Following up in the ticket comments
RebeccaTamachiro
added a commit
that referenced
this pull request
Apr 21, 2025
* Add custom cipher suites to plans/index.json * Add per-hostname min TLS version to plans/index.json * Fix formatting for certs included * Process comments from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PCX-9785
PCX-9877