Skip to content

[SSL] Add missing features and fix formatting for cert limits #21016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 21, 2025
Merged

[SSL] Add missing features and fix formatting for cert limits #21016

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75b0622
Add custom cipher suites to plans/index.json
RebeccaTamachiro Mar 21, 2025
072672f
Add per-hostname min TLS version to plans/index.json
RebeccaTamachiro Mar 21, 2025
ebe27ee
Fix formatting for certs included
RebeccaTamachiro Mar 21, 2025
6b5d9fa
Process comments from code review
RebeccaTamachiro Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 33 additions & 10 deletions src/content/plans/index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2491,9 +2491,9 @@
},
"quantity": {
"title": "Certificates included",
"free": 0,
"pro": 0,
"pro_plus": 1,
"free": "0",
"pro": "0",
"pro_plus": "1",
Copy link
Contributor

@pedrosousa pedrosousa Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: There's something strange here, because in the plans page we're not getting the "Pro Plus" label, only the value:
image

https://rebecca-ssl-features-and-cert-limits.preview.developers.cloudflare.com/plans/#:~:text=Business%3A%201%20(Modern)%201%20(Legacy)

Maybe it's an issue in the Plans page itself.

Copy link
Contributor Author

@RebeccaTamachiro RebeccaTamachiro Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, weird. Following up in the ticket comments

"biz": "1 (Modern)\n1 (Legacy)",
"ent": "1 (Modern) (can purchase more)\n1 (Legacy) (can purchase more)"
}
Expand Down Expand Up @@ -2601,6 +2601,13 @@
"pro": "Yes",
"biz": "Yes",
"ent": "Yes"
},
"per_hostname": {
"title": "Per-hostname",
"free": "Included with [Advanced Certificate Manager](/ssl/edge-certificates/advanced-certificate-manager/)",
"pro": "Included with [Advanced Certificate Manager](/ssl/edge-certificates/advanced-certificate-manager/)",
"biz": "Included with [Advanced Certificate Manager](/ssl/edge-certificates/advanced-certificate-manager/)",
"ent": "Included with [Advanced Certificate Manager](/ssl/edge-certificates/advanced-certificate-manager/)"
}
}
},
Expand Down Expand Up @@ -2637,16 +2644,16 @@
"b_initial_quota": {
"title": "Hostnames included",
"summary": "Varies",
"free": 100,
"pro": 100,
"biz": 100,
"ent": 0
"free": "100",
"pro": "100",
"biz": "100",
"ent": "0"
},
"c_max_hostnames": {
"title": "Max hostnames",
"free": 5000,
"pro": 5000,
"biz": 5000,
"free": "5000",
"pro": "5000",
"biz": "5000",
"ent": "Unlimited, but contact sales if using over 5000."
},
"custom_analytics": {
Expand Down Expand Up @@ -2824,6 +2831,22 @@
}
}
},
"custom_cipher_suites": {
"title": "Custom cipher suites",
"link": "/ssl/edge-certificates/additional-options/cipher-suites/customize-cipher-suites/",
"paid_add_on": true,
"paid_add_on_plans": ["free", "pro", "biz", "ent"],
"properties": {
"availability": {
"title": "Availability",
"summary": "Custom cipher suites are available for domains that have purchased [Advanced Certificate Manager](/ssl/edge-certificates/advanced-certificate-manager/) and are currently using a [full DNS setup](/dns/zone-setups/full-setup/).",
"free": "Included with [Advanced Certificate Manager](/ssl/edge-certificates/advanced-certificate-manager/)",
"pro": "Included with [Advanced Certificate Manager](/ssl/edge-certificates/advanced-certificate-manager/)",
"biz": "Included with [Advanced Certificate Manager](/ssl/edge-certificates/advanced-certificate-manager/)",
"ent": "Included with [Advanced Certificate Manager](/ssl/edge-certificates/advanced-certificate-manager/)"
}
}
},
"total_tls": {
"title": "Total TLS",
"link": "/ssl/edge-certificates/additional-options/total-tls/",
Expand Down