-
Notifications
You must be signed in to change notification settings - Fork 10.1k
[Secrets Store] Review for consistency and clarity in examples and limits #21795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RebeccaTamachiro
merged 9 commits into
production
from
rebecca/secrets-store-follow-up-mdx
Apr 21, 2025
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5b8f80f
Fix access-control info about Account Super Admins
RebeccaTamachiro 7784fdd
Revise examples so bindings vs secret names are not mixed up
RebeccaTamachiro 5d7781f
Touch up example secret name in commands.mdx
RebeccaTamachiro b5811b1
Make prereqs and local dev callouts clearer
RebeccaTamachiro afa0542
Fix typo and add monospaced h3s for consistency
RebeccaTamachiro cc2f9f1
Fix order to match list at the top of the page
RebeccaTamachiro f20c251
Improve context and cross-linking
RebeccaTamachiro 553167e
Clarify maximum of 20 secrets only apply to production
RebeccaTamachiro fde531c
Use placeholder for binding variable and apply throughout
RebeccaTamachiro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to double check. In
binding =the customer isn't supposed to input their secret; rather they should write the var"secrets_store_binding"?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really. I think originally it wasn't added as a placeholder (in between
<>) bc of the concrete example at the bottom but I'll update both to have the placeholders instead. Thank you!