-
Notifications
You must be signed in to change notification settings - Fork 9.9k
[Ruleset Engine] Move tables to lists #23914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ruleset Engine] Move tables to lists #23914
Conversation
| [dr-zone]: /api/resources/rulesets/methods/delete/ | ||
| - [Delete an account ruleset rule](/api/resources/rulesets/subresources/rules/methods/delete/)<br/> | ||
| `DELETE /accounts/{account_id}/rulesets/{ruleset_id}/rules/{rule_id}` | ||
| - [Delete a zone ruleset rule](/api/resources/rulesets/subresources/rules/methods/delete/)<br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link was fixed.
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
| [ur-zone]: /api/resources/rulesets/methods/update/ | ||
| - [Update an account ruleset rule](/api/resources/rulesets/subresources/rules/methods/edit/)<br/> | ||
| `PATCH /accounts/{account_id}/rulesets/{ruleset_id}/rules/{rule_id}` | ||
| - [Update a zone ruleset rule](/api/resources/rulesets/subresources/rules/methods/edit/)<br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link was fixed.
| | Operation | Method + Endpoint | | ||
| | -------------------------------------------- | ------------------------------------------------------------------------------------------------------ | | ||
| | List rules in account ruleset version by tag | `GET /accounts/{account_id}/rulesets/{managed_ruleset_id}/versions/{version_number}/by_tag/{tag_name}` | | ||
| - List an account ruleset version's rules by tag<br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed according to the name in the API schema.
Summary
Converts endpoints tables to lists to improve readability (especially on mobile).
Also fixes a couple of links to the API reference.