-
Notifications
You must be signed in to change notification settings - Fork 9.9k
[Ruleset Engine] Move tables to lists #23914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pedrosousa
merged 1 commit into
production
from
pedro/2025-07-23-rule-eng-tables-to-lists
Jul 24, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,13 +12,10 @@ Applies one or more changes to an existing rule in a ruleset at the account or z | |
|
|
||
| Use one of the following API endpoints: | ||
|
|
||
| | Operation | Method + Endpoint | | ||
| | -------------------------------------------- | -------------------------------------------------------------------- | | ||
| | [Update an account ruleset rule][ur-account] | `PATCH /accounts/{account_id}/rulesets/{ruleset_id}/rules/{rule_id}` | | ||
| | [Update a zone ruleset rule][ur-zone] | `PATCH /zones/{zone_id}/rulesets/{ruleset_id}/rules/{rule_id}` | | ||
|
|
||
| [ur-account]: /api/resources/rulesets/subresources/rules/methods/edit/ | ||
| [ur-zone]: /api/resources/rulesets/methods/update/ | ||
| - [Update an account ruleset rule](/api/resources/rulesets/subresources/rules/methods/edit/)<br/> | ||
| `PATCH /accounts/{account_id}/rulesets/{ruleset_id}/rules/{rule_id}` | ||
| - [Update a zone ruleset rule](/api/resources/rulesets/subresources/rules/methods/edit/)<br/> | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This link was fixed. |
||
| `PATCH /zones/{zone_id}/rulesets/{ruleset_id}/rules/{rule_id}` | ||
|
|
||
| You can update the definition of the rule, changing its fields, or change the order of the rule in the ruleset. Invoking this method creates a new version of the ruleset. | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,13 +20,10 @@ Returns the list of existing rulesets at the account level or at the zone level. | |
|
|
||
| Use one of the following API endpoints: | ||
|
|
||
| | Operation | Method + Endpoint | | ||
| | ----------------------------------- | ------------------------------------- | | ||
| | [List account rulesets][lr-account] | `GET /accounts/{account_id}/rulesets` | | ||
| | [List zone rulesets][lr-zone] | `GET /zones/{zone_id}/rulesets` | | ||
|
|
||
| [lr-account]: /api/resources/rulesets/methods/list/ | ||
| [lr-zone]: /api/resources/rulesets/methods/list/ | ||
| - [List account rulesets](/api/resources/rulesets/methods/list/)<br/> | ||
| `GET /accounts/{account_id}/rulesets` | ||
| - [List zone rulesets](/api/resources/rulesets/methods/list/)<br/> | ||
| `GET /zones/{zone_id}/rulesets` | ||
|
|
||
| The result includes rulesets across all phases at a given level (account or zone). The `phase` field in each result element indicates the [phase](/ruleset-engine/about/phases/) where that ruleset is defined. | ||
|
|
||
|
|
@@ -67,17 +64,14 @@ Returns the properties of the most recent version of the ruleset with the specif | |
|
|
||
| Use one of the following API endpoints: | ||
|
|
||
| | Operation | Method + Endpoint | | ||
| | ------------------------------------------------- | -------------------------------------------------------------------- | | ||
| | [Get an account ruleset][gr-account] | `GET /accounts/{account_id}/rulesets/{ruleset_id}` | | ||
| | [Get a zone ruleset][gr-zone] | `GET /zones/{zone_id}/rulesets/{ruleset_id}` | | ||
| | [Get an account entry point ruleset][gep-account] | `GET /accounts/{account_id}/rulesets/phases/{phase_name}/entrypoint` | | ||
| | [Get a zone entry point ruleset][gep-zone] | `GET /zones/{zone_id}/rulesets/phases/{phase_name}/entrypoint` | | ||
|
|
||
| [gr-account]: /api/resources/rulesets/methods/get/ | ||
| [gr-zone]: /api/resources/rulesets/methods/get/ | ||
| [gep-account]: /api/resources/rulesets/subresources/phases/methods/get/ | ||
| [gep-zone]: /api/resources/rulesets/subresources/phases/methods/get/ | ||
| - [Get an account ruleset](/api/resources/rulesets/methods/get/)<br/> | ||
| `GET /accounts/{account_id}/rulesets/{ruleset_id}` | ||
| - [Get an account entry point ruleset](/api/resources/rulesets/subresources/phases/methods/get/)<br/> | ||
| `GET /accounts/{account_id}/rulesets/phases/{phase_name}/entrypoint` | ||
| - [Get a zone ruleset](/api/resources/rulesets/methods/get/)<br/> | ||
| `GET /zones/{zone_id}/rulesets/{ruleset_id}` | ||
| - [Get a zone entry point ruleset](/api/resources/rulesets/subresources/phases/methods/get/)<br/> | ||
| `GET /zones/{zone_id}/rulesets/phases/{phase_name}/entrypoint` | ||
|
|
||
| :::note | ||
| You can only use the _Get a zone ruleset_ operation for zone-level phase entry points (entry points where `kind` is set to `zone`). | ||
|
|
@@ -127,17 +121,14 @@ Returns a list of all the versions of a ruleset. | |
|
|
||
| Use one of the following API endpoints: | ||
|
|
||
| | Operation | Method + Endpoint | | ||
| | -------------------------------------------------------- | ----------------------------------------------------------------------------- | | ||
| | [List account ruleset versions][lv-account] | `GET /accounts/{account_id}/rulesets/{ruleset_id}/versions` | | ||
| | [List zone ruleset versions][lv-zone] | `GET /zones/{zone_id}/rulesets/{ruleset_id}/versions` | | ||
| | [List account entry point ruleset versions][lev-account] | `GET /accounts/{account_id}/rulesets/phases/{phase_name}/entrypoint/versions` | | ||
| | [List zone entry point ruleset versions][lev-zone] | `GET /zones/{zone_id}/rulesets/phases/{phase_name}/entrypoint/versions` | | ||
|
|
||
| [lv-account]: /api/resources/rulesets/subresources/versions/methods/list/ | ||
| [lv-zone]: /api/resources/rulesets/subresources/versions/methods/list/ | ||
| [lev-account]: /api/resources/rulesets/subresources/phases/subresources/versions/methods/list/ | ||
| [lev-zone]: /api/resources/rulesets/subresources/phases/subresources/versions/methods/list/ | ||
| - [List account ruleset versions](/api/resources/rulesets/subresources/versions/methods/list/)<br/> | ||
| `GET /accounts/{account_id}/rulesets/{ruleset_id}/versions` | ||
| - [List account entry point ruleset versions](/api/resources/rulesets/subresources/phases/subresources/versions/methods/list/)<br/> | ||
| `GET /accounts/{account_id}/rulesets/phases/{phase_name}/entrypoint/versions` | ||
| - [List zone ruleset versions](/api/resources/rulesets/subresources/versions/methods/list/)<br/> | ||
| `GET /zones/{zone_id}/rulesets/{ruleset_id}/versions` | ||
| - [List zone entry point ruleset versions](/api/resources/rulesets/subresources/phases/subresources/versions/methods/list/)<br/> | ||
| `GET /zones/{zone_id}/rulesets/phases/{phase_name}/entrypoint/versions` | ||
|
|
||
| The result contains the ruleset properties of each version, but it does not include the list of rules. Refer to [View a specific version of a ruleset](#view-a-specific-version-of-a-ruleset) for instructions on obtaining this information. | ||
|
|
||
|
|
@@ -184,17 +175,14 @@ Returns the configuration of a specific version of a ruleset, including its rule | |
|
|
||
| Use one of the following API endpoints: | ||
|
|
||
| | Operation | Method + Endpoint | | ||
| | ---------------------------------------------------------- | ---------------------------------------------------------------------------------------------- | | ||
| | [Get an account ruleset version][grv-account] | `GET /account/{account_id}/rulesets/{ruleset_id}/versions/{version_number}` | | ||
| | [Get a zone ruleset version][grv-zone] | `GET /zones/{zone_id}/rulesets/{ruleset_id}/versions/{version_number}` | | ||
| | [Get an account entry point ruleset version][gerv-account] | `GET /accounts/{account_id}/rulesets/phases/{phase_name}/entrypoint/versions/{version_number}` | | ||
| | [Get a zone entry point ruleset version][gerv-zone] | `GET /zones/{zone_id}/rulesets/phases/{phase_name}/entrypoint/versions/{version_number}` | | ||
|
|
||
| [grv-account]: /api/resources/rulesets/subresources/versions/methods/get/ | ||
| [grv-zone]: /api/resources/rulesets/subresources/versions/methods/get/ | ||
| [gerv-account]: /api/resources/rulesets/subresources/phases/subresources/versions/methods/get/ | ||
| [gerv-zone]: /api/resources/rulesets/subresources/phases/subresources/versions/methods/get/ | ||
| - [Get an account ruleset version](/api/resources/rulesets/subresources/versions/methods/get/)<br/> | ||
| `GET /account/{account_id}/rulesets/{ruleset_id}/versions/{version_number}` | ||
| - [Get an account entry point ruleset version](/api/resources/rulesets/subresources/phases/subresources/versions/methods/get/)<br/> | ||
| `GET /accounts/{account_id}/rulesets/phases/{phase_name}/entrypoint/versions/{version_number}` | ||
| - [Get a zone ruleset version](/api/resources/rulesets/subresources/versions/methods/get/)<br/> | ||
| `GET /zones/{zone_id}/rulesets/{ruleset_id}/versions/{version_number}` | ||
| - [Get a zone entry point ruleset version](/api/resources/rulesets/subresources/phases/subresources/versions/methods/get/)<br/> | ||
| `GET /zones/{zone_id}/rulesets/phases/{phase_name}/entrypoint/versions/{version_number}` | ||
|
|
||
| When the specified phase entry point ruleset does not exist, this API method returns a `404 Not Found` HTTP status code. | ||
|
|
||
|
|
@@ -242,9 +230,8 @@ When you view a specific version of a managed ruleset, each rule listed in the r | |
|
|
||
| Returns a list of all the rules in a managed ruleset with a specific tag. | ||
|
|
||
| | Operation | Method + Endpoint | | ||
| | -------------------------------------------- | ------------------------------------------------------------------------------------------------------ | | ||
| | List rules in account ruleset version by tag | `GET /accounts/{account_id}/rulesets/{managed_ruleset_id}/versions/{version_number}/by_tag/{tag_name}` | | ||
| - List an account ruleset version's rules by tag<br/> | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renamed according to the name in the API schema. |
||
| `GET /accounts/{account_id}/rulesets/{ruleset_id}/versions/{version_number}/by_tag/{tag_name}` | ||
|
|
||
| ### Example | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link was fixed.