Skip to content

[D1] Fixing instances of D1 all() to run() #24148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2025
Merged

[D1] Fixing instances of D1 all() to run() #24148

merged 1 commit into from
Aug 4, 2025

Conversation

@Oxyjun
Copy link
Contributor

@Oxyjun Oxyjun commented Aug 4, 2025 •
edited
Loading

Summary

D1's all() method is an alias to run(), and we recommend users to use run().

This PR replaces instances of code examples which were using all() to run() for consistency with our recommendation.

Closes #24137.

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@github-actions github-actions bot added the size/s label Aug 4, 2025
@github-actions github-actions bot added product:d1 D1: https://developers.cloudflare.com/d1/ product:pages product:workers Related to Workers product product:workers-ai Workers AI: https://developers.cloudflare.com/workers-ai/ product:workflows Workflows: https://developers.cloudflare.com/workflows/ labels Aug 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/d1/ @elithrar, @rozenmd, @vy-ton, @joshthoward, @oxyjun, @harshil1712, @cloudflare/pcx-technical-writing
/src/content/docs/pages/framework-guides/ @igorminar, @cloudflare/wrangler, @aninibread, @GregBrimble, @kodster28, @cloudflare/pcx-technical-writing
/src/content/docs/workers-ai/ @rita3ko, @craigsdennis, @markdembo, @mchenco, @kodster28, @cloudflare/pcx-technical-writing
/src/content/docs/workers/ @cloudflare/workers-docs, @GregBrimble, @irvinebroque, @mikenomitch, @korinne, @WalshyDev, @cloudflare/deploy-config, @cloudflare/pcx-technical-writing, @kodster28, @cloudflare/wrangler, @cloudflare/workers-runtime-1, @cloudflare/wrangler
/src/content/docs/workflows/ @elithrar, @celso, @cloudflare/pcx-technical-writing

@Oxyjun Oxyjun mentioned this pull request Aug 4, 2025
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

Preview URL: https://c9e61f9e.preview.developers.cloudflare.com
Preview Branch URL: https://jun-d1-all-to-run.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/d1/examples/d1-and-hono/ https://jun-d1-all-to-run.preview.developers.cloudflare.com/d1/examples/d1-and-hono/
https://developers.cloudflare.com/d1/get-started/ https://jun-d1-all-to-run.preview.developers.cloudflare.com/d1/get-started/
https://developers.cloudflare.com/d1/tutorials/build-a-comments-api/ https://jun-d1-all-to-run.preview.developers.cloudflare.com/d1/tutorials/build-a-comments-api/
https://developers.cloudflare.com/d1/best-practices/local-development/ https://jun-d1-all-to-run.preview.developers.cloudflare.com/d1/best-practices/local-development/
https://developers.cloudflare.com/d1/best-practices/remote-development/ https://jun-d1-all-to-run.preview.developers.cloudflare.com/d1/best-practices/remote-development/
https://developers.cloudflare.com/d1/examples/d1-and-remix/ https://jun-d1-all-to-run.preview.developers.cloudflare.com/d1/examples/d1-and-remix/
https://developers.cloudflare.com/d1/examples/query-d1-from-python-workers/ https://jun-d1-all-to-run.preview.developers.cloudflare.com/d1/examples/query-d1-from-python-workers/
https://developers.cloudflare.com/d1/sql-api/sql-statements/ https://jun-d1-all-to-run.preview.developers.cloudflare.com/d1/sql-api/sql-statements/
https://developers.cloudflare.com/d1/tutorials/build-a-staff-directory-app/ https://jun-d1-all-to-run.preview.developers.cloudflare.com/d1/tutorials/build-a-staff-directory-app/
https://developers.cloudflare.com/d1/tutorials/using-read-replication-for-e-com/ https://jun-d1-all-to-run.preview.developers.cloudflare.com/d1/tutorials/using-read-replication-for-e-com/
https://developers.cloudflare.com/d1/worker-api/ https://jun-d1-all-to-run.preview.developers.cloudflare.com/d1/worker-api/
https://developers.cloudflare.com/pages/framework-guides/deploy-a-remix-site/ https://jun-d1-all-to-run.preview.developers.cloudflare.com/pages/framework-guides/deploy-a-remix-site/
https://developers.cloudflare.com/workers-ai/guides/tutorials/build-a-retrieval-augmented-generation-ai/ https://jun-d1-all-to-run.preview.developers.cloudflare.com/workers-ai/guides/tutorials/build-a-retrieval-augmented-generation-ai/
https://developers.cloudflare.com/workers/languages/python/examples/ https://jun-d1-all-to-run.preview.developers.cloudflare.com/workers/languages/python/examples/
https://developers.cloudflare.com/workers/runtime-apis/bindings/service-bindings/rpc/ https://jun-d1-all-to-run.preview.developers.cloudflare.com/workers/runtime-apis/bindings/service-bindings/rpc/

@Oxyjun Oxyjun merged commit 3c83ed2 into production Aug 4, 2025
11 checks passed
@Oxyjun Oxyjun deleted the jun/d1/all-to-run branch August 4, 2025 10:48
thomasgauvin pushed a commit that referenced this pull request Aug 15, 2025
@Oxyjun @thomasgauvin
Fixing instances of D1 all() to run() (#24148)
2e9dde2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marciocloudflare marciocloudflare marciocloudflare approved these changes

@elithrar elithrar Awaiting requested review from elithrar elithrar is a code owner

@celso celso Awaiting requested review from celso celso is a code owner

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

@aninibread aninibread Awaiting requested review from aninibread aninibread is a code owner

@GregBrimble GregBrimble Awaiting requested review from GregBrimble GregBrimble is a code owner

@kodster28 kodster28 Awaiting requested review from kodster28 kodster28 is a code owner

@irvinebroque irvinebroque Awaiting requested review from irvinebroque irvinebroque is a code owner

@mikenomitch mikenomitch Awaiting requested review from mikenomitch mikenomitch is a code owner

@korinne korinne Awaiting requested review from korinne korinne is a code owner

@WalshyDev WalshyDev Awaiting requested review from WalshyDev WalshyDev is a code owner

@rozenmd rozenmd Awaiting requested review from rozenmd rozenmd is a code owner

@vy-ton vy-ton Awaiting requested review from vy-ton vy-ton is a code owner

@joshthoward joshthoward Awaiting requested review from joshthoward joshthoward is a code owner

@harshil1712 harshil1712 Awaiting requested review from harshil1712 harshil1712 is a code owner

@rita3ko rita3ko Awaiting requested review from rita3ko rita3ko is a code owner

@craigsdennis craigsdennis Awaiting requested review from craigsdennis craigsdennis is a code owner

@markdembo markdembo Awaiting requested review from markdembo

@mchenco mchenco Awaiting requested review from mchenco mchenco is a code owner

Assignees

@elithrar elithrar

@IgorMinar IgorMinar

@rozenmd rozenmd

@GregBrimble GregBrimble

@joshthoward joshthoward

@vy-ton vy-ton

@harshil1712 harshil1712

@kodster28 kodster28

@aninibread aninibread

@Oxyjun Oxyjun

Labels

product:d1 D1: https://developers.cloudflare.com/d1/ product:pages product:workers Related to Workers product product:workers-ai Workers AI: https://developers.cloudflare.com/workers-ai/ product:workflows Workflows: https://developers.cloudflare.com/workflows/ size/s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

d1 prepared statement missing all() in documentation