Make the Help dropdown and Light/Dark Mode dropdown UI consistent - #30575
Closed
ahaywood wants to merge 2 commits into
Closed
Make the Help dropdown and Light/Dark Mode dropdown UI consistent#30575ahaywood wants to merge 2 commits into
ahaywood wants to merge 2 commits into
Conversation
Replace the Starlight ThemeSelect component with a custom ThemeSelectDropdown React component. Add width constraint wrapper and remove associated CSS rules for the old component. Add React JSX type definition for starlight-theme-select custom element. Format multi-property transition declarations across multiple lines for consistency.
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Preview URL: https://038b48c5.preview.developers.cloudflare.com |
Contributor
|
Hey there, we've marked this pull request as stale because there's no recent activity on it. This label helps us identify PRs that might need updates (or to be closed out by our team if no longer relevant). |
Contributor
|
Hey there, we've closed out this pull request because it's been stale for a while and there's been no additional action on it. If these changes are still relevant, open a new pull request (or flag to us in a GitHub issue). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before:
The Help dropdown menu and the light / dark mode dropdown did not match:
After:
The items were displayed differently because the Gelp dropdown implemented a React dropdown menu. The light/dark mode dropdown utilized a standard HTML
select.This PR moves the light/dark mode dropdown to a React dropdown (
ThemeSelectDropdown) that matches the help menu and replaces the StarlightThemeSelectcomponent.I kept a hidden
selectinput within the new React component so that the code continues to leverage the pre-existing JavaScript listener andStarlightThemeProvider.Screenshots
In the video, the content flash signals a page refresh:
https://github.com/user-attachments/assets/79ffe65f-fda5-47a3-84ba-a39a4e5e9fd9