Reject reports earlier than task_config.not_before#755
Closed
Conversation
jhoyla
requested review from
RageKnify,
armfazh,
bhalleycf,
cbranch,
cjpatton,
fisherdarling,
lbaquerofierro and
mendess
as code owners
cjpatton
approved these changes
Jan 1, 2025
jhoyla
force-pushed
the
jhoyla/public-extensions
branch
4 times, most recently
from
eda9b3c to
5078b99
Compare
jhoyla
force-pushed
the
jhoyla/add-start-time-to-task-param
branch
5 times, most recently
from
73e42e6 to
83664c1
Compare
jhoyla
force-pushed
the
jhoyla/public-extensions
branch
from
28ff330 to
0287417
Compare
jhoyla
force-pushed
the
jhoyla/add-start-time-to-task-param
branch
2 times, most recently
from
fcc8dc1 to
77ab628
Compare
jhoyla
force-pushed
the
jhoyla/public-extensions
branch
from
0287417 to
8f8e5b9
Compare
jhoyla
force-pushed
the
jhoyla/add-start-time-to-task-param
branch
from
77ab628 to
f4a7076
Compare
jhoyla
force-pushed
the
jhoyla/public-extensions
branch
from
7e5cd9e to
afbafd0
Compare
cjpatton
force-pushed
the
jhoyla/public-extensions
branch
4 times, most recently
from
483032d to
f0bc7b1
Compare
jhoyla
force-pushed
the
jhoyla/add-start-time-to-task-param
branch
from
f4a7076 to
167397c
Compare
jhoyla
force-pushed
the
jhoyla/add-start-time-to-task-param
branch
from
167397c to
dc6d896
Compare
cjpatton
requested changes
Jan 23, 2025
Contributor
cjpatton
left a comment
cjpatton
left a comment
There was a problem hiding this comment.
I'm start working on this and put up a new PR once I've figured out the bug.
Contributor
|
Closing in favor of #768. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft-13 changes how time is described in the draft, but the only externally visible change is rejecting reports earlier than task_config.not_before. This PR implements that behaviour, but doesn't adjust our internal representation.