run container tests on CI

[anonrig]

Let's run container tests on CI

[gpanders]

@anonrig @danlapid Container tests (and associated images) are now built and run by Bazel in Linux CI. Please re-review when you're able.

[github-actions]

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

[fhanau]

@gpanders This looks like it should be several PRs – one making test changes, one adding container tests to CI. Easier to review that way.
The changes look good for the most part (only took a brief look so far). Do you have numbers for how much overhead this adds? As I understand you already only run this in the test-linux job, but keep in mind that the workers-sdk-test job depends on test-linux and runs after it, so test-linux may be in the critical path for CI duration already.

[gpanders]

@gpanders This looks like it should be several PRs – one making test changes, one adding container tests to CI. Easier to review that way.

This PR only does the latter. The only changes to the tests are those that were required to get them to work when run by Bazel.

The changes look good for the most part (only took a brief look so far). Do you have numbers for how much overhead this adds? As I understand you already only run this in the test-linux job, but keep in mind that the workers-sdk-test job depends on test-linux and runs after it, so test-linux may be in the critical path for CI duration already.

Using https://github.com/cloudflare/workerd/actions/runs/19862763581/job/56917088984 as a reference, the "Build and load container images step" adds 14s. "Bazel build" took 3m13s and "Bazel test" took 1m5s. Compared to https://github.com/cloudflare/workerd/actions/runs/19832826061/job/56822887495 (which is the last commit on main that this PR is based on right now), where "Bazel build" took 4m7s and "Bazel test" took 1m46s. The large difference is probably due to caching. But it doesn't seem like this PR adds any significant time.

I'll add too that I'm working on this PR at @anonrig's request, who asked that this be done before #5491 is merged. I'll leave it up to you all whether or not you want to run these tests in CI, as long as we can unblock #5491.

[danlapid]

@gpanders This looks like it should be several PRs – one making test changes, one adding container tests to CI. Easier to review that way.

This PR only does the latter. The only changes to the tests are those that were required to get them to work when run by Bazel.

The changes look good for the most part (only took a brief look so far). Do you have numbers for how much overhead this adds? As I understand you already only run this in the test-linux job, but keep in mind that the workers-sdk-test job depends on test-linux and runs after it, so test-linux may be in the critical path for CI duration already.

Using cloudflare/workerd/actions/runs/19862763581/job/56917088984 as a reference, the "Build and load container images step" adds 14s. "Bazel build" took 3m13s and "Bazel test" took 1m5s. Compared to cloudflare/workerd/actions/runs/19832826061/job/56822887495 (which is the last commit on main that this PR is based on right now), where "Bazel build" took 4m7s and "Bazel test" took 1m46s. The large difference is probably due to caching. But it doesn't seem like this PR adds any significant time.

I'll add too that I'm working on this PR at @anonrig's request, who asked that this be done before #5491 is merged. I'll leave it up to you all whether or not you want to run these tests in CI, as long as we can unblock #5491.

We definitely want these tests in CI.
This PR does not need to be split, it is perfectly reasonable as it is.
We can accept the additional test time required to run these tests.

[fhanau]

LGTM otherwise