Skip to content

Conversation

@nikitassharma
Copy link
Member

Custom instance types could previously only be set through setting vcpu/memory/disk through the configuration block. As we deprecate configuration, move setting vcpu, memory, and disk to the instance type field of wrangler. By nature, this enforces that custom instance types are mutually exclusive with the named instance types and will allow us to remove a lot of the logic that verifies this once configuration is removed.

Fixes CC-5692


@nikitassharma nikitassharma requested review from a team as code owners July 23, 2025 17:17
@changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2025

🦋 Changeset detected

Latest commit: 7b04192

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main nsharma/custom-instance-type might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-10051
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@nikitassharma nikitassharma added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jul 23, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 23, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10051

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10051

miniflare

npm i https://pkg.pr.new/miniflare@10051

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10051

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10051

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10051

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10051

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10051

wrangler

npm i https://pkg.pr.new/wrangler@10051

commit: 7b04192

Copy link
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and as i mentioned, this'll need changes to containers/config.ts and everything downstream of that :)

@github-project-automation github-project-automation bot moved this from Untriaged to In Review in workers-sdk Jul 25, 2025
Custom instance types could previously only be set through setting
vcpu/memory/disk through the `configuration` block. As we deprecate
`configuration`, move setting vcpu, memory, and disk to the instance
type field of wrangler. By nature, this enforces that custom instance
types are mutually exclusive with the named instance types and will
allow us to remove a lot of the logic that verifies this once
`configuration` is removed.
@nikitassharma nikitassharma force-pushed the nsharma/custom-instance-type branch from 5a413f1 to 17cba03 Compare July 28, 2025 19:10
Copy link
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending the commented changes, but don't want to block you on time zones :)

@github-project-automation github-project-automation bot moved this from In Review to Approved in workers-sdk Jul 29, 2025
@nikitassharma nikitassharma merged commit 0f7820e into main Jul 30, 2025
48 of 51 checks passed
@nikitassharma nikitassharma deleted the nsharma/custom-instance-type branch July 30, 2025 15:12
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 30, 2025
@nikitassharma nikitassharma restored the nsharma/custom-instance-type branch July 30, 2025 19:02
@nikitassharma nikitassharma deleted the nsharma/custom-instance-type branch July 30, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants