CC-5692: Add support for custom instance types #9962
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8f109f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
emily-shen
force-pushed
the
emily/extra-validation
branch
2 times, most recently
from
fd70f4f to
ddbc4dc
Compare
nikitassharma
force-pushed
the
nsharma/custom-instance-type
branch
from
163304c to
eb6f1aa
Compare
nikitassharma
changed the base branch from
emily/extra-validation
to
emily/containers-config-2
6 tasks
nikitassharma
force-pushed
the
nsharma/custom-instance-type
branch
from
eb6f1aa to
4f74942
Compare
emily-shen
force-pushed
the
emily/containers-config-2
branch
from
1ac19c2 to
8e33339
Compare
Merged
1 task
emily-shen
force-pushed
the
emily/containers-config-2
branch
from
8e33339 to
e2a434d
Compare
nikitassharma
force-pushed
the
nsharma/custom-instance-type
branch
from
4f74942 to
cbb7baf
Compare
emily-shen
force-pushed
the
emily/containers-config-2
branch
2 times, most recently
from
4546eb3 to
ddbc4dc
Compare
emily-shen
force-pushed
the
emily/containers-config-2
branch
from
ddbc4dc to
a1ee29a
Compare
Custom instance types could previously only be set through setting vcpu/memory/disk through the `configuration` block. As we deprecate `configuration`, move setting vcpu, memory, and disk to the instance type field of wrangler. By nature, this enforces that custom instance types are mutually exclusive with the named instance types and will allow us to remove a lot of the logic that verifies this once `configuration` is removed.
nikitassharma
force-pushed
the
nsharma/custom-instance-type
branch
from
cbb7baf to
8f109f1
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
emily-shen
force-pushed
the
emily/containers-config-2
branch
11 times, most recently
from
bfe7096 to
b30a797
Compare
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom instance types could previously only be set through setting vcpu/memory/disk through the
configurationblock. As we deprecateconfiguration, move setting vcpu, memory, and disk to the instance type field of wrangler. By nature, this enforces that custom instance types are mutually exclusive with the named instance types and will allow us to remove a lot of the logic that verifies this onceconfigurationis removed.Fixes CC-5692