add more validation to containers config

[emily-shen]

Fixes CC-5480

• validates types for all fields
• warns for unexpected fields
• warns on deprecated fields

---

• Tests
  • Tests included
  • Tests not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: config already documented
• Wrangler V3 Backport
  • Wrangler PR:
  • Not necessary because: not in v3

[changeset-bot]

🦋 Changeset detected

Latest commit: ddbc4dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
wrangler	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9934

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9934

miniflare

npm i https://pkg.pr.new/miniflare@9934

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9934

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9934

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9934

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9934

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9934

wrangler

npm i https://pkg.pr.new/wrangler@9934

commit: ddbc4dc

[github-actions]

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main emily/extra-validation might be a good starting point.

Notes:

• your PR branch should be named v3-backport-9934
• add the skip-v3-pr label to the current PR to stop this workflow from failing

[dario-piotrowicz]

LGTM 🙂

[IRCody]

Agree with @nikitassharma's suggestion but other than that LGTM.

[gpanders]

I don't think vcpu and memory_mib are included in configuration?

workers-sdk/packages/wrangler/src/config/environment.ts

Lines 109 to 114 in 64af5da

	configuration?: {
	image?: string;
	labels?: { name: string; value: string }[];
	secrets?: { name: string; type: "env"; secret: string }[];
	disk?: { size: string };
	};

Users shouldn't be able to set these directly in the Wrangler config anyway, they are set by the instance type.

[nikitassharma]

these fields are being used right now for customers that need custom instance types, see #9962 for better handling for custom instance types

[gpanders]

Do they need to be added to the type definition then?

[emily-shen]

i'd strongly prefer to have them in the type definition so that we're not trying to read values that typescript doesn't expect to be there. they're hidden from the wrangler config schema, so we don't need to worry about showing this to the general user.

[nikitassharma]

I agree, they should be in the type definition