allow WRANGLER_SEND_ERROR_REPORTS to override whether to report Wrangler crashes to Sentry #10735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

petebacondarwin merged 2 commits into main from pbd/add-no-sentry-env-var

Oct 3, 2025

Contributor

petebacondarwin commented Sep 23, 2025 •

edited

Loading

Fixes #10719

Tests
- Tests included
- Tests not necessary because:
Public documentation
- Cloudflare docs PR(s): update Wrangler env-vars to include WRANGLER_LOG_SANITIZE and WRANGLER_SEND_ERROR_REPORTS cloudflare-docs#25605
- Documentation not necessary because:
Wrangler V3 Backport
- Wrangler PR: V3 Backport [#10735]: allow WRANGLER_SEND_ERROR_REPORTS to override whether to report Wrangler crashes to Sentry #10737
- Not necessary because:

petebacondarwin requested a review from a team as a code owner

September 23, 2025 15:43

changeset-bot bot commented Sep 23, 2025 •

edited

Loading

🦋 Changeset detected

Latest commit: d1d268d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

workers-devprod added this to workers-sdk

github-project-automation bot moved this to Untriaged in workers-sdk

workers-devprod mentioned this pull request

V3 Backport [#10735]: allow WRANGLER_SEND_ERROR_REPORTS to override whether to report Wrangler crashes to Sentry #10737

Open

Contributor

github-actions bot commented Sep 23, 2025 •

edited

Loading

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main pbd/add-no-sentry-env-var might be a good starting point.

Notes:

your PR branch should be named v3-backport-10735
add the skip-v3-pr label to the current PR to stop this workflow from failing

pkg-pr-new bot commented Sep 23, 2025 •

edited

Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10735

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10735

miniflare

npm i https://pkg.pr.new/miniflare@10735

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10735

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10735

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10735

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10735

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10735

wrangler

npm i https://pkg.pr.new/wrangler@10735

commit: d1d268d

petebacondarwin mentioned this pull request

Can't get rid of prompt when wrangler D1 command has error. #10719

Closed

petebacondarwin force-pushed the pbd/add-no-sentry-env-var branch 4 times, most recently from b1728b2 to 0070ce4 Compare

September 30, 2025 12:57

edmundhung reviewed

View reviewed changes

packages/wrangler/src/sentry/index.ts Outdated Show resolved Hide resolved

petebacondarwin force-pushed the pbd/add-no-sentry-env-var branch from 0070ce4 to 71e0b1c Compare

October 2, 2025 13:18

petebacondarwin added 2 commits

October 2, 2025 14:45


          allow WRANGLER_SEND_METRICS to override whether to report Wrangler cr…

8e42f8e

…ashes to Sentry


          fixup! allow WRANGLER_SEND_METRICS to override whether to report Wran…

d1d268d

…gler crashes to Sentry

petebacondarwin force-pushed the pbd/add-no-sentry-env-var branch from 71e0b1c to d1d268d Compare

October 2, 2025 13:46

petebacondarwin changed the title ~~allow WRANGLER_SEND_METRICS to override whether to report Wrangler crashes to Sentry~~ allow WRANGLER_SEND_ERROR_REPORTS to override whether to report Wrangler crashes to Sentry

petebacondarwin added the skip-v3-pr label

petebacondarwin requested a review from edmundhung

October 2, 2025 16:06

edmundhung approved these changes

View reviewed changes

Member

edmundhung left a comment

Approved with a few nits.

We probably want to update the docs for the new env var as well.

packages/wrangler/src/__tests__/sentry.test.ts

    
              					event_id: "",

              					sdk: {

              						name: "sentry.javascript.node",

              						version: "7.87.0",

Member

edmundhung Oct 2, 2025

This will require us to update the test when ever we update the sentry client. Would it be better to match it with expect.any(String) instead?

There are a few more version number above.

packages/wrangler/src/__tests__/sentry.test.ts

    
              					sent_at: "",

              					trace: {

              						environment: "production",

              						public_key: "9edbb8417b284aa2bbead9b4c318918b",

Member

edmundhung Oct 2, 2025

Looks like a magic number that could change? Maybe match it with expect.any(String) as well?

packages/wrangler/src/__tests__/sentry.test.ts

    
              					sent_at: "",

              					trace: {

              						environment: "production",

              						public_key: "9edbb8417b284aa2bbead9b4c318918b",

Member

edmundhung Oct 2, 2025

Suggested change

      
            						public_key: "9edbb8417b284aa2bbead9b4c318918b",
          
            						public_key: expect.any(String),

packages/wrangler/src/__tests__/sentry.test.ts

    
              					event_id: "",

              					sdk: {

              						name: "sentry.javascript.node",

              						version: "7.87.0",

Member

edmundhung Oct 2, 2025

Suggested change

      
            						version: "7.87.0",
          
            						version: expect.any(String),

packages/wrangler/src/__tests__/sentry.test.ts

    
              								version: "7.87.0",

              							},

              						],

              						version: "7.87.0",

Member

edmundhung Oct 2, 2025

Suggested change

      
            						version: "7.87.0",
          
            						version: expect.any(String),

packages/wrangler/src/__tests__/sentry.test.ts

    
              						packages: [

              							{

              								name: "npm:@sentry/node",

              								version: "7.87.0",

Member

edmundhung Oct 2, 2025

Suggested change

      
            								version: "7.87.0",
          
            								version: expect.any(String),

github-project-automation bot moved this from Untriaged to Approved in workers-sdk

edmundhung reviewed

View reviewed changes

.changeset/angry-apes-share.md

    
            @@ -0,0 +1,5 @@
          
              ---

              "wrangler": patch

Member

edmundhung Oct 2, 2025

Is this a fix or new feature? 🤔

Contributor Author

petebacondarwin Oct 3, 2025

I'll bump it to minor

Contributor Author

petebacondarwin commented Oct 3, 2025

Thanks for the review @edmundhung - the new Sentry test is an exact copy of another test in that file. So there is no new reliance upon magic constants that wasn't there before. We can improve that in another PR, but so far it seems that we have rarely been bothered by it - perhaps because there has not been any update to that dependency in a long time?

Contributor Author

petebacondarwin commented Oct 3, 2025

Created a docs PR: cloudflare/cloudflare-docs#25605

petebacondarwin merged commit 103fbf0 into main

54 of 58 checks passed

petebacondarwin deleted the pbd/add-no-sentry-env-var branch

October 3, 2025 07:29

github-project-automation bot moved this from Approved to Done in workers-sdk

workers-devprod mentioned this pull request

Version Packages #10852

Merged

petebacondarwin mentioned this pull request

(bug/feature) Ability for .toml / .jsonc file to set a variable to allow disable error reporting prompt #10578

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels