Skip to content

Conversation

dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Oct 6, 2025

Fixes #10885

Before (on the left) and after (on the right):
Screenshot 2025-10-06 at 19 11 48

Note

The output is only an aspect of this change, what's more important is the fact that the new diffing logic includes information of what fields have changed (and how), making the diff usable for further logic (e.g. local config patching)


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: QoL improvement
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not a V3 feature

Copy link

changeset-bot bot commented Oct 6, 2025

🦋 Changeset detected

Latest commit: 5ec53ae

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 6, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10892

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10892

miniflare

npm i https://pkg.pr.new/miniflare@10892

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10892

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10892

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10892

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10892

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10892

wrangler

npm i https://pkg.pr.new/wrangler@10892

commit: 5ec53ae

@dario-piotrowicz dario-piotrowicz force-pushed the dario/10885/improved-json-diffing branch 15 times, most recently from 8a1a251 to 1c0765c Compare October 7, 2025 00:29
@dario-piotrowicz dario-piotrowicz force-pushed the dario/10885/improved-json-diffing branch from 1c0765c to 5ec53ae Compare October 7, 2025 00:37
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review October 7, 2025 09:08
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner October 7, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

Improve wrangler json diffing logic
1 participant