fix: add printResourceLocation to D1 commands #10912
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7657
This PR adds
printResourceLocation: true
to the behaviour configuration of D1 commands that support--local
/--remote
flags. This enables these commands to display whether they're running against local or remote databases before showing any confirmation prompts, eliminating user confusion about which database will be affected.What Changed
Added
printResourceLocation: true
to four D1 commands:wrangler d1 execute
wrangler d1 export
wrangler d1 migrations apply
wrangler d1 migrations list
How It Works
The
printResourceLocation
feature is already implemented in the command framework (register-yargs-command.ts
). When enabled, it:--local
/--remote
flags in the command argumentsisLocal()
helperThis same pattern is already used successfully in KV and R2 commands.
Human Review Checklist
Most important to verify:
--local
/--remote
flags?)printResourceLocation
logic will work properly with D1 command argument structuresAdditional items:
Link to Devin run: https://app.devin.ai/sessions/97e9a99e8308471185de7052745a358f
Requested by: @smacleod