Skip to content

fix: add printResourceLocation to D1 commands #10912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −0
Draft

fix: add printResourceLocation to D1 commands #10912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/add-d1-print-resource-location.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"wrangler": patch
---

fix: show local/remote status before D1 command confirmations

D1 commands (`execute`, `export`, `migrations apply`, `migrations list`) now display whether they're running against local or remote databases before showing confirmation prompts. This prevents confusion about which database will be affected by the operation.
1 change: 1 addition & 0 deletions packages/wrangler/src/d1/execute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export const d1ExecuteCommand = createCommand({
},
behaviour: {
printBanner: (args) => !args.json,
printResourceLocation: true,
},
args: {
database: {
Expand Down
3 changes: 3 additions & 0 deletions packages/wrangler/src/d1/export.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ export const d1ExportCommand = createCommand({
status: "stable",
owner: "Product: D1",
},
behaviour: {
printResourceLocation: true,
},
args: {
name: {
type: "string",
Expand Down
3 changes: 3 additions & 0 deletions packages/wrangler/src/d1/migrations/apply.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ export const d1MigrationsApplyCommand = createCommand({
status: "stable",
owner: "Product: D1",
},
behaviour: {
printResourceLocation: true,
},
args: {
database: {
type: "string",
Expand Down
3 changes: 3 additions & 0 deletions packages/wrangler/src/d1/migrations/list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ export const d1MigrationsListCommand = createCommand({
status: "stable",
owner: "Product: D1",
},
behaviour: {
printResourceLocation: true,
},
args: {
database: {
type: "string",
Expand Down
Loading