Skip to content

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Apr 3, 2025

adds a new option so that developers can opt out of esbuild's keep_names option
(see: https://esbuild.github.io/api/#keep-names) which wrangler otherwise sets
to true

this is something developers should not usually need to care about, but sometimes
keep_names can create issues, in such cases they will be now able to opt out of it


This should fix:


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: new Wrangler feature

@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2025

🦋 Changeset detected

Latest commit: dd3eb6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-wrangler-8771

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8771/npm-package-wrangler-8771

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-wrangler-8771 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-workers-bindings-extension-8771 -O ./cloudflare-workers-bindings-extension.0.0.0-ve3deae81b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-ve3deae81b.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-create-cloudflare-8771 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-kv-asset-handler-8771

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-miniflare-8771

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-pages-shared-8771

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-unenv-preset-8771

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-vite-plugin-8771

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-vitest-pool-workers-8771

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-workers-editor-shared-8771

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-workers-shared-8771

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-workflows-shared-8771

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250321.1
workerd 1.20250321.0 1.20250321.0
workerd --version 1.20250321.0 2025-03-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could do with a test, but otherwise LGTM

@dario-piotrowicz
Copy link
Member Author

This could do with a test

of course I wasn't planning on skipping on the testing 😄👍
(that's why it's still in draft, I also do need to add this in our docs)

but otherwise LGTM

thanks! 🫶

@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2025

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-wrangler-8771
Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-workers-bindings-extension-8771 -O ./cloudflare-workers-bindings-extension.0.0.0-vc759b05ba.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vc759b05ba.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-create-cloudflare-8771 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-kv-asset-handler-8771

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-miniflare-8771

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-pages-shared-8771

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-unenv-preset-8771

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-vite-plugin-8771

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-vitest-pool-workers-8771

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-workers-editor-shared-8771

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-workers-shared-8771

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-workflows-shared-8771

Note that these links will no longer work once the GitHub Actions artifact expires.

@dario-piotrowicz dario-piotrowicz added the e2e Run wrangler + vite-plugin e2e tests on a PR label Apr 22, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/wrangler_keep_names branch from a2245c5 to ffc7e74 Compare April 22, 2025 15:37
@dario-piotrowicz
Copy link
Member Author

This could do with a test, but otherwise LGTM

Tests added 🙂 , I didn't go overboard and just added a minimal one, please let me know if you think that this is sufficient or if you believe that we'd want more testing around this 🙂

@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review April 22, 2025 15:39
@dario-piotrowicz dario-piotrowicz requested review from a team as code owners April 22, 2025 15:39
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks.

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 22, 2025
@dario-piotrowicz dario-piotrowicz merged commit 0cfcfe0 into main Apr 22, 2025
18 of 19 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/wrangler_keep_names branch April 22, 2025 21:10
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 22, 2025
IRCody pushed a commit that referenced this pull request Apr 23, 2025
---------

Co-authored-by: Somhairle MacLeòid <[email protected]>
@vicb vicb mentioned this pull request Jun 7, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants