-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: add config.keep_names option
#8771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: dd3eb6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-wrangler-8771You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8771/npm-package-wrangler-8771Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-wrangler-8771 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-workers-bindings-extension-8771 -O ./cloudflare-workers-bindings-extension.0.0.0-ve3deae81b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-ve3deae81b.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-create-cloudflare-8771 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-kv-asset-handler-8771miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-miniflare-8771@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-pages-shared-8771@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-unenv-preset-8771@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-vite-plugin-8771@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-vitest-pool-workers-8771@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-workers-editor-shared-8771@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-workers-shared-8771@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14246394624/npm-package-cloudflare-workflows-shared-8771Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
penalosa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could do with a test, but otherwise LGTM
of course I wasn't planning on skipping on the testing 😄👍
thanks! 🫶 |
b38ca55 to
80835ca
Compare
|
A Wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-wrangler-8771Prereleases for other packages:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-workers-bindings-extension-8771 -O ./cloudflare-workers-bindings-extension.0.0.0-vc759b05ba.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vc759b05ba.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-create-cloudflare-8771 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-kv-asset-handler-8771
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-miniflare-8771
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-pages-shared-8771
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-unenv-preset-8771
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-vite-plugin-8771
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-vitest-pool-workers-8771
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-workers-editor-shared-8771
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-workers-shared-8771
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14599173985/npm-package-cloudflare-workflows-shared-8771Note that these links will no longer work once the GitHub Actions artifact expires. |
Co-authored-by: Somhairle MacLeòid <[email protected]>
a2245c5 to
ffc7e74
Compare
Tests added 🙂 , I didn't go overboard and just added a minimal one, please let me know if you think that this is sufficient or if you believe that we'd want more testing around this 🙂 |
petebacondarwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks.
--------- Co-authored-by: Somhairle MacLeòid <[email protected]>
adds a new option so that developers can opt out of esbuild's
keep_namesoption(see: https://esbuild.github.io/api/#keep-names) which wrangler otherwise sets
to
truethis is something developers should not usually need to care about, but sometimes
keep_namescan create issues, in such cases they will be now able to opt out of itThis should fix:
ReferenceError: __name is not definedinawait page.evaluate(async () => {...}#7107keep_namesoption to wrangler config docs cloudflare-docs#21896