feat: Update the GolangCi-lint version

[ZPascal]

Summary

• Adjust all linting results

[aramprice]

@ZPascal thanks for tackling this cleanup!

I know generally we've added //nolint:... directives. I'm wondering if it's worth a quick scan of consumers of bosh-utils (in the CF org at least) to see if it's safe to address some of the issues with errors.New(), rather than dropping //nolint:....

[ZPascal]

@ZPascal thanks for tackling this cleanup!

I know generally we've added //nolint:... directives. I'm wondering if it's worth a quick scan of consumers of bosh-utils (in the CF org at least) to see if it's safe to address some of the issues with errors.New(), rather than dropping //nolint:....

Hi @aramprice, if we're not using nolint, it is a breaking change. -> It is also necessary to adapt the error message to follow ST1005.

BTW: The bosh-utils package is also used outside of the cf org.

[aramprice]

BTW: The bosh-utils package is also used outside of the cf org.

I'm aware, I was thinking this might be a good litmus test. I also think it's risky as a consumer to depend on strings from errors ... and I think that risk is something that consumers of a library should assume. Also I realize lack of good typing in the library might make it impossible not to rely on error text.

Generally it would be great for us to reduce the need for //nolint:..., though the error format is more of a nit, than a structure code risk (like ignoring errors, say).

Also I'm good with the changes, as is.

[ZPascal]

BTW: The bosh-utils package is also used outside of the cf org.

I'm aware, I was thinking this might be a good litmus test. I also think it's risky as a consumer to depend on strings from errors ... and I think that risk is something that consumers of a library should assume. Also I realize lack of good typing in the library might make it impossible not to rely on error text.

Generally it would be great for us to reduce the need for //nolint:..., though the error format is more of a nit, than a structure code risk (like ignoring errors, say).

I'm on your side. It would be better to fix it. I've already fixed all lint issues on my end and will push it.

[beyhan]

@ZPascal could you please resolve the conflicts?

[ZPascal]

@ZPascal could you please resolve the conflicts?

I'll handle it.

[aramprice]

Thanks @ZPascal