Add feature flags to v1 app manifests#4358
Merged
philippthun merged 2 commits intocloudfoundry:mainfrom Jun 2, 2025
Merged
Conversation
philippthun
changed the title
philippthun
force-pushed
the
features-in-manifest
branch
from
d5d3d87 to
1cf79e1
Compare
- introduce AppFeatures helper containing constants and the mapping to database columns - add FeaturesPresenter - wire into AppManifestPresenter - update request and unit tests for new 'features' hash
philippthun
force-pushed
the
features-in-manifest
branch
4 times, most recently
from
4fe3f45 to
1a06b43
Compare
philippthun
force-pushed
the
features-in-manifest
branch
2 times, most recently
from
05aa06f to
e770c0f
Compare
svkrieger
reviewed
May 30, 2025
- add bulk_update method to AppFeatureUpdate - add features to manifest message - call AppFeatureUpdate from AppApplyManifest - add features to SpaceDiffManifest - update API docs
philippthun
force-pushed
the
features-in-manifest
branch
from
e770c0f to
3f5781b
Compare
svkrieger
approved these changes
Jun 2, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Jun 2, 2025
Changes in cloud_controller_ng:
- Add feature flags to v1 app manifests
PR: cloudfoundry/cloud_controller_ng#4358
Author: Philipp Thun <philipp.thun@sap.com>
This was referenced Jun 2, 2025
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow app features to be set via manifest. Features are specified as follows (per app):
Features are shown in the generated manifest for an app (
GET /v3/apps/:guid/manifest) and taken into account when calculating the manifest diff (POST /v3/spaces/:guid/manifest_diff).I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests