Adding a warning for legacy route usage#1785
Open
karrgov wants to merge 4 commits intocloudfoundry:masterfrom
Open
Adding a warning for legacy route usage#1785karrgov wants to merge 4 commits intocloudfoundry:masterfrom
karrgov wants to merge 4 commits intocloudfoundry:masterfrom
Conversation
LMCROSSITXSADEPLOY-3413
| public static final String TRIPLE_APPENDED_STRING = "%s%s%s"; | ||
| public static final String SECURE_EXTENSION_DESCRIPTOR_ID = "__mta.secure"; | ||
| public static final String STRING_SEPARATOR = "-"; | ||
| public static final String DEPRECATED_ROUTE_MARKER = "cfapps"; |
Contributor
There was a problem hiding this comment.
I'd suggest to changeto: ".cfapps."
| // Progress messages | ||
| public static final String OPERATION_ID = "Operation ID: {0}"; | ||
| public static final String MTA_SCHEMA_VERSION_DETECTED_AS = "Detected MTA schema version: \"{0}\""; | ||
| public static final String LEGACY_ROUTE_DEPLOY_SERVICE_DEPRECATED = "You are using legacy route https://deploy-service.cfapps.<domain> of SAP Cloud Deployment service. It will be deprecated and removed in the end of 2026. To avoid issues in the future, update all workflows to use the proper SAP Cloud Deployment route https://deploy-service.cf.<domain> (replace \"cfapps\" with \"cf\"). More information: https://me.sap.com/notes/3695458"; |
Contributor
There was a problem hiding this comment.
As this message is quite related to SAP. I'd suggest to move it in the internal project. Override the step and print the message there.
LMCROSSITXSADEPLOY-3413
IvanBorislavovDimitrov
previously approved these changes
Feb 26, 2026
LMCROSSITXSADEPLOY-3413
| .startProcess(ArgumentMatchers.eq("deploy"), ArgumentMatchers.argThat( | ||
| map -> map.containsKey(Variables.MTA_ID.getName()) && map.containsKey(Variables.EXT_DESCRIPTOR_FILE_ID.getName()) | ||
| && !map.containsKey(Variables.CTS_PROCESS_ID.getName()) && !map.containsKey(Variables.DEPLOY_URI.getName()))); | ||
| && !map.containsKey(Variables.CTS_PROCESS_ID.getName()) && !map.containsKey(Variables.CTS_PASSWORD.getName()))); |
Contributor
There was a problem hiding this comment.
Why DEPLOY_URI was removed and replaced with CTS_PASSWORD variable?
theghost5800
previously approved these changes
Feb 26, 2026
IvanBorislavovDimitrov
previously approved these changes
Feb 26, 2026
LMCROSSITXSADEPLOY-3413
karrgov
dismissed stale reviews from IvanBorislavovDimitrov and theghost5800
via
e0aed09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LMCROSSITXSADEPLOY-3413