Refactor password grant #3165
Merged
Refactor password grant #3165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
strehle
commented
Nov 28, 2024
strehle
commented
- if origin is available, retrieve IdP and check if password can be used
- use always identityProviderProvisioning and remove externalOAuthProviderConfigurator
* if origin is available, retrieve IdP and check if password can be used * use always identityProviderProvisioning and remove externalOAuthProviderConfigurator
...org/cloudfoundry/identity/uaa/authentication/manager/PasswordGrantAuthenticationManager.java
Outdated
Show resolved
Hide resolved
...org/cloudfoundry/identity/uaa/authentication/manager/PasswordGrantAuthenticationManager.java
Outdated
Show resolved
Hide resolved
adrianhoelzl-sap
approved these changes
Nov 29, 2024
Contributor
|
@strehle I believe this caused a regression with the password grant. If the IdP config only has the discoveryUrl set, the identityProviderProvisioning lookup does not fill in the tokenUrl like the externalOAuthProviderConfigurator did, and this results in a NullPointerException here: |
Member
Author
|
@mikeroda ok, we can check ( FYI @adrianhoelzl-sap ) because this PR was created as optimization for IDP look. Can you either create an issue ticket with information about type of IdP (oauth or oidc) and then simply discovery only and you do password grant correct ? |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.