fix: private video poster image #833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kalifyaniv-cloudinary
approved these changes
Mar 25, 2025
Contributor
kalifyaniv-cloudinary
left a comment
kalifyaniv-cloudinary
left a comment
There was a problem hiding this comment.
crazy that this is the fix! 👏
jakub-roch
approved these changes
Mar 26, 2025
tsi
commented
Mar 26, 2025
Comment on lines
+41
to
+46
| text-shadow: | ||
| 0 0 0.1em var(--color-accent), | ||
| 0 0 0.2em var(--color-accent), | ||
| 0 0 0.3em var(--color-accent), | ||
| 0 0 0.8em var(--color-text), | ||
| 0 0 1em var(--color-text); |
Collaborator
Author
There was a problem hiding this comment.
Added some accent to our focus highlight following this feedback.
Didn't mean to push it to this PR but I'll let it slide...
This was referenced Dec 10, 2025
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken poster image on assets with private delivery type (codepen)