Skip to content

fix: private video poster image #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsi merged 5 commits into from
Mar 26, 2025
Merged

fix: private video poster image #833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
59a811c
fix: private video poster image
tsi Mar 25, 2025
e69d207
fix: improve focus accent
tsi Mar 26, 2025
dab7c00
Merge branch 'master' into ME-19132-private-asset-poster
tsi Mar 26, 2025
ec39cb1
fix: improve focus accent
tsi Mar 26, 2025
f2909ea
Merge branch 'ME-19132-private-asset-poster' of https://github.com/cl…
tsi Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/assets/styles/main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,12 @@ $icon-font-path: '../icon-font' !default;
&:focus,
&:focus:before {
outline: none;
text-shadow: 0 0 1em var(--color-text);
text-shadow:
0 0 0.1em var(--color-accent),
0 0 0.2em var(--color-accent),
0 0 0.3em var(--color-accent),
0 0 0.8em var(--color-text),
0 0 1em var(--color-text);
Comment on lines +41 to +46
Copy link
Collaborator Author

@tsi tsi Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some accent to our focus highlight following this feedback.
Didn't mean to push it to this PR but I'll let it slide...

}
}

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/cloudinary/models/video-source/video-source.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class VideoSource extends BaseSource {
this.withCredentials = !!withCredentials;
this.getInitOptions = () => initOptions;

this.poster(poster);
this.poster(poster, options);
this.sourceTypes(sourceTypes);
this.sourceTransformation(sourceTransformation);
this.info(info);
Expand Down