feat: Allow to include symbols in binaries during package
#1974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
changed the title
package
erezrokah
requested review from
a team,
bbernays and
ronsh12
and removed request for
ronsh12
murarustefaan
approved these changes
Nov 22, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
🤖 I have created a release *beep* *boop* --- ## [4.69.0](v4.68.3...v4.69.0) (2024-11-22) ### Features * Allow to include symbols in binaries during `package` ([#1974](#1974)) ([aa3b3e4](aa3b3e4)) ### Bug Fixes * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.28.4 ([#1968](#1968)) ([4e35df7](4e35df7)) * **deps:** Update module google.golang.org/protobuf to v1.35.2 ([#1971](#1971)) ([7076899](7076899)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Nov 25, 2024
#### Summary This PR is intended to add a FIPS version of the test source plugin, it works only for linux arm64 and amd64, since that's what `boringcrypto` [supports](https://github.com/golang/go/blob/4865aadc21acebc8039f914929f03c7042b2ae8d/src/crypto/boring/boring_test.go#L16). Needs cloudquery/plugin-sdk#1974 for validation
5 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
May 19, 2025
#### Summary This should fix embedding plugin version, I broke this a while back #1974 ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Without the symbols it's hard to validate we're generating FIPS compliant binaries (see https://github.com/cloudquery/cloudquery-issues/issues/2586 and https://github.com/cloudquery/cloudquery/pull/19676/files#diff-3613eb0da60aba72ff182962b6ae3a738e42369d8bed0407cba78ba7cc72f052R101).
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)