Skip to content

Conversation

@orangevolon
Copy link
Member

@orangevolon orangevolon commented Dec 2, 2024

Description

We moved the test utils generation code to the test-utils repo here. This PR removes the redundant code and reuses the utils exported from the test-utils repo.

No functional changes are expected. The snapshot diffs must be only spacings/ordering.

Similar to: cloudscape-design/chat-components#35, cloudscape-design/code-view#54, cloudscape-design/components#3087

How has this been tested?

We have already implemented functional tests both in the test-utils repo and components repo which generates actual test utils and tries to query dom with the generated test utils.

  • Unit tests for test utils.
  • Unit tests for components.

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.94%. Comparing base (ea5364e) to head (6ec011f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files          61       61           
  Lines        4312     4312           
  Branches      741      740    -1     
=======================================
  Hits         4051     4051           
- Misses        259      261    +2     
+ Partials        2        0    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@just-boris just-boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All places where I left comment look good for me. For the rest of the PR, I would count on @georgylobko to give the final ship-it

@orangevolon orangevolon added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 926aa1d Jan 20, 2025
39 of 40 checks passed
@orangevolon orangevolon deleted the chore/adds-test-utils-build-scripts branch January 20, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants