Skip to content

Conversation

@orangevolon
Copy link
Member

@orangevolon orangevolon commented Dec 2, 2024

Description

We moved the test utils generation code to the test-utils repo here. This PR removes the redundant code and reuses the utils exported from the test-utils repo.

No functional changes are expected. The snapshot diffs must be only spacings/ordering.

Similar to: cloudscape-design/code-view#54, cloudscape-design/components#3087, cloudscape-design/board-components#332

How has this been tested?

We have already implemented functional tests both in the test-utils repo and components repo which generates actual test utils and tries to query dom with the generated test utils.

  • Unit tests for test utils.
  • Unit tests for components.

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.23%. Comparing base (aefa6da) to head (7528343).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files          19       19           
  Lines         520      520           
  Branches       61       61           
=======================================
  Hits          516      516           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orangevolon orangevolon force-pushed the chore/adds-test-utils-build-scripts branch from 589140c to 7528343 Compare January 17, 2025 10:59
@orangevolon orangevolon marked this pull request as ready for review January 17, 2025 14:09
"dev": true
},
"node_modules/react-keyed-flatten-children": {
"version": "1.3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are changes in this file expected?

Copy link
Member Author

@orangevolon orangevolon Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes as a result of running npm install and runnning the prepare-package-json.js afterwards via Git hooks. If we don't commit that, it needs to be updated in the next PR anyways I guess.

Copy link
Member Author

@orangevolon orangevolon Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update has happened here: cloudscape-design/components@dd1ae7e

@orangevolon orangevolon requested a review from abdhalees January 20, 2025 13:58
@orangevolon orangevolon added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 81f675f Jan 22, 2025
38 of 39 checks passed
@orangevolon orangevolon deleted the chore/adds-test-utils-build-scripts branch January 22, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants