-
Notifications
You must be signed in to change notification settings - Fork 6
chore: Replaces the test utils script with centralized one #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b66c924 to
589140c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 19 19
Lines 520 520
Branches 61 61
=======================================
Hits 516 516
Misses 4 4 ☔ View full report in Codecov by Sentry. |
589140c to
7528343
Compare
| "dev": true | ||
| }, | ||
| "node_modules/react-keyed-flatten-children": { | ||
| "version": "1.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are changes in this file expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes as a result of running npm install and runnning the prepare-package-json.js afterwards via Git hooks. If we don't commit that, it needs to be updated in the next PR anyways I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update has happened here: cloudscape-design/components@dd1ae7e
Description
We moved the test utils generation code to the
test-utilsrepo here. This PR removes the redundant code and reuses the utils exported from thetest-utilsrepo.No functional changes are expected. The snapshot diffs must be only spacings/ordering.
Similar to: cloudscape-design/code-view#54, cloudscape-design/components#3087, cloudscape-design/board-components#332
How has this been tested?
We have already implemented functional tests both in the
test-utilsrepo andcomponentsrepo which generates actual test utils and tries to query dom with the generated test utils.Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.