fix: Sanitize URL in prepare-package-lock script #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } else if (dependency.resolved && dependency.resolved.includes("codeartifact.us-west-2.amazonaws.com")) { | ||
| } else if ( | ||
| dependency.resolved && | ||
| new URL(dependency.resolved).host.endsWith("codeartifact.us-west-2.amazonaws.com") |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 6 months ago
To fix the issue, we need to ensure that the host is explicitly validated as either the exact domain codeartifact.us-west-2.amazonaws.com or one of its subdomains. This can be achieved by parsing the URL and checking the host against a whitelist of allowed domains. Specifically, we should verify that the host is either codeartifact.us-west-2.amazonaws.com or ends with .codeartifact.us-west-2.amazonaws.com but is not preceded by an arbitrary string.
The fix involves:
- Parsing the
dependency.resolvedURL using theURLconstructor. - Checking if the host matches
codeartifact.us-west-2.amazonaws.comor ends with.codeartifact.us-west-2.amazonaws.comwhile ensuring it is a valid subdomain.
Suggested changeset
1
scripts/prepare-package-lock.js
| @@ -27,3 +27,7 @@ | ||
| dependency.resolved && | ||
| new URL(dependency.resolved).host.endsWith("codeartifact.us-west-2.amazonaws.com") | ||
| (() => { | ||
| const host = new URL(dependency.resolved).host; | ||
| return host === "codeartifact.us-west-2.amazonaws.com" || | ||
| host.endsWith(".codeartifact.us-west-2.amazonaws.com"); | ||
| })() | ||
| ) { |
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
Member
Author
There was a problem hiding this comment.
Addressed in latest commit
pan-kot
approved these changes
Aug 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes sure that the check does not give false positives (for example, by the string being found in URL parameters).
Related links, issue #, if available: Code Scanning alert #5
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.