Skip to content

fix: Sanitize URL in prepare-package-lock script #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jperals merged 5 commits into from
Oct 17, 2025
Merged

fix: Sanitize URL in prepare-package-lock script #71

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d2a9450
fix: Sanitize URL in prepare-package-lock script
jperals Jul 25, 2025
0365cff
Better check for subdomain
jperals Jul 25, 2025
1f5c614
Merge branch 'main' into fix/url-sanitization
jperals Aug 4, 2025
973ce63
Merge branch 'main' into fix/url-sanitization
jperals Oct 8, 2025
22763c5
Merge branch 'main' into fix/url-sanitization
jperals Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions scripts/prepare-package-lock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,27 @@ if (packageLock.lockfileVersion !== 2) {
throw new Error('package-lock.json must have "lockfileVersion": 2');
}

const disallowedHosts = [
{
host: "codeartifact.us-west-2.amazonaws.com",
errorMessage:
"package-lock.json file contains a reference to CodeArtifact. Use regular npm to update the packages.",
},
];

function unlock(packages) {
Object.keys(packages).forEach((dependencyName) => {
const dependency = packages[dependencyName];

if (dependencyName.includes("@cloudscape-design/")) {
delete packages[dependencyName];
} else if (dependency.resolved && dependency.resolved.includes("codeartifact.us-west-2.amazonaws.com")) {
throw Error(
"package-lock.json file contains a reference to CodeArtifact. Use regular npm to update the packages.",
);
} else if (dependency.resolved) {
const host = new URL(dependency.resolved).host;
for (const disalloweHost of disallowedHosts) {
if (host === disalloweHost.host || host.endsWith(`.${disalloweHost.host}`)) {
throw Error(disalloweHost.errorMessage);
}
}
}
});

Expand Down
Loading